Re: [PATCH 00/11] notmuch insert updates

diff --git a/fe/860a215856e9709f988acb04216e0047a5cf21 b/fe/860a215856e9709f988acb04216e0047a5cf21
new file mode 100644 (file)
index 0000000..97b6cb1
--- /dev/null
+++ b/fe/860a215856e9709f988acb04216e0047a5cf21
@@ -0,0 +1,74 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 95486431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Sep 2014 01:13:55 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 1YoV2XTjO6ln for <notmuch@notmuchmail.org>;\r
+       Thu, 25 Sep 2014 01:13:48 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id F1770431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 25 Sep 2014 01:13:47 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XX4BN-0004aZ-Q2; Thu, 25 Sep 2014 05:13:45 -0300\r
+Received: (nullmailer pid 27379 invoked by uid 1000); Thu, 25 Sep 2014\r
+       08:13:40 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] notmuch insert updates\r
+In-Reply-To: <cover.1411379395.git.jani@nikula.org>\r
+References: <cover.1411379395.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 25 Sep 2014 10:13:40 +0200\r
+Message-ID: <878ul815jf.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 25 Sep 2014 08:13:55 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> This series refactors and cleans up insert, improves error handling and\r
+> reporting, and adds post-insert hook. I intend to add documentation and\r
+> more tests, but the code is ready for review. Also, at least some of the\r
+> cleanups and fixes in the beginning of the series could go in without\r
+> additional tests or documentation.\r
+\r
+The first 4 seem trivial, and I marked them so.\r
+\r
+5-8 don't introduce new functionality, and don't break \r
+any existing tests. Subject to a little more review, these could \r
+probably be merged now.\r
+\r
+5 is almost trivial; it wouldn't hurt to explicitly document the return\r
+values of sync_dir, while touching this code.\r
+\r
+6 and 8 seem ok, but should probably have another pair of eyes.\r
+\r
+7 seems ok. At first I worried about the usual issue of races between\r
+name definition and open, but it seems like nothing changes here.\r
+\r
+\r