Re: [PATCH v4] lib: Simplify close and codify aborting atomic section

diff --git a/42/396ae2452b0f85ffb80cc3760080490ce8a23d b/42/396ae2452b0f85ffb80cc3760080490ce8a23d
new file mode 100644 (file)
index 0000000..d12798e
--- /dev/null
+++ b/42/396ae2452b0f85ffb80cc3760080490ce8a23d
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6B0A9431FBF\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 01:48:29 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kDRhl7zuw4Mu for <notmuch@notmuchmail.org>;\r
+       Fri,  3 Oct 2014 01:48:24 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id ABFC0431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 01:48:24 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XZyXH-0005nG-9C; Fri, 03 Oct 2014 05:48:23 -0300\r
+Received: (nullmailer pid 17015 invoked by uid 1000); Fri, 03 Oct 2014\r
+       08:48:13 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4] lib: Simplify close and codify aborting atomic section\r
+In-Reply-To: <1412277548-3445-1-git-send-email-aclements@csail.mit.edu>\r
+References: <87mw9ee0vf.fsf@csail.mit.edu>\r
+       <1412277548-3445-1-git-send-email-aclements@csail.mit.edu>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 03 Oct 2014 10:48:13 +0200\r
+Message-ID: <87oattr12q.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 03 Oct 2014 08:48:29 -0000\r
+\r
+Austin Clements <aclements@csail.mit.edu> writes:\r
+\r
+> This patch simplifies notmuch_database_close to explicitly abort any\r
+> outstanding transaction and then just call Database::close.  This\r
+> works for both read-only and read/write databases, takes care of\r
+> committing changes, unifies the exception handling path, and codifies\r
+> aborting outstanding transactions.  This is currently the only way to\r
+> abort an atomic section (and may remain so, since it would be\r
+> difficult to roll back things we may have cached from rolled-back\r
+> modifications).\r
+\r
+pushed\r
+\r
+d\r