Re: notmuch-reply doesn't use Reply-To

diff --git a/0f/8ab0d8a300e2d2ca5a964a222f3f8d461fe627 b/0f/8ab0d8a300e2d2ca5a964a222f3f8d461fe627
new file mode 100644 (file)
index 0000000..925abba
--- /dev/null
+++ b/0f/8ab0d8a300e2d2ca5a964a222f3f8d461fe627
@@ -0,0 +1,78 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 68A1A6DE02AD\r
+ for <notmuch@notmuchmail.org>; Wed, 23 Mar 2016 03:35:26 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.027\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.027 tagged_above=-999 required=5\r
+ tests=[AWL=-0.016, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id MaCizaZ_xki7 for <notmuch@notmuchmail.org>;\r
+ Wed, 23 Mar 2016 03:35:18 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 3EED76DE02A9\r
+ for <notmuch@notmuchmail.org>; Wed, 23 Mar 2016 03:35:18 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1aig8k-0002qN-7p; Wed, 23 Mar 2016 06:35:50 -0400\r
+Received: (nullmailer pid 8853 invoked by uid 1000);\r
+ Wed, 23 Mar 2016 10:35:12 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, Damien Cassou <damien@cassou.me>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: notmuch-reply doesn't use Reply-To\r
+In-Reply-To: <87twnygmps.fsf@nikula.org>\r
+References: <8737vjcx9b.fsf@cassou.me> <8737vi8l7j.fsf@zancas.localnet>\r
+ <87fuzi9ng5.fsf@cassou.me> <87twnygmps.fsf@nikula.org>\r
+User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 23 Mar 2016 07:35:12 -0300\r
+Message-ID: <8760wdlbxb.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 23 Mar 2016 10:35:26 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+>>\r
+>> Here is the reply message, and it does not contain the address in Reply-To.\r
+>\r
+> This was true way back when notmuch reply only knew about reply all. For\r
+> --reply-to=sender, it's broken. The simplest "fix" might be\r
+>\r
+> diff --git a/notmuch-reply.c b/notmuch-reply.c\r
+> index 6df54fc992bb..ed0f9cca5c00 100644\r
+> --- a/notmuch-reply.c\r
+> +++ b/notmuch-reply.c\r
+> @@ -334,7 +334,7 @@ add_recipients_from_message (GMimeMessage *reply,\r
+>       * that the address in the Reply-To header will always appear in\r
+>       * the reply.\r
+>       */\r
+> -    if (reply_to_header_is_redundant (message)) {\r
+> +    if (reply_to_header_is_redundant (message) && reply_all) {\r
+>         reply_to_map[0].header = "from";\r
+>         reply_to_map[0].fallback = NULL;\r
+>      }\r
+\r
+I'm going to mark this fixed for now, since the docs have now been\r
+updated to match the behaviour.\r
+\r
+d\r