[PATCH 1/2] STYLE: document some rules about variable declarations

diff --git a/3e/2e0a764150c7431eebc9c9fc568030809336a9 b/3e/2e0a764150c7431eebc9c9fc568030809336a9
new file mode 100644 (file)
index 0000000..bac33e4
--- /dev/null
+++ b/3e/2e0a764150c7431eebc9c9fc568030809336a9
@@ -0,0 +1,79 @@
+Return-Path: <bremner@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 1CE666DE0AF8\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Feb 2016 09:11:27 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.307\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.307 tagged_above=-999 required=5 tests=[AWL=0.244,\r
+  RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id TVJ8ETaEBGqV for <notmuch@notmuchmail.org>;\r
+ Sat, 13 Feb 2016 09:11:25 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 60ED26DE0A9A\r
+ for <notmuch@notmuchmail.org>; Sat, 13 Feb 2016 09:11:25 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <bremner@tethera.net>)\r
+ id 1aUdiV-0004K3-5I; Sat, 13 Feb 2016 12:10:43 -0500\r
+Received: (nullmailer pid 9990 invoked by uid 1000);\r
+ Sat, 13 Feb 2016 17:11:23 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 1/2] STYLE: document some rules about variable declarations\r
+Date: Sat, 13 Feb 2016 13:11:18 -0400\r
+Message-Id: <1455383479-9946-1-git-send-email-david@tethera.net>\r
+X-Mailer: git-send-email 2.6.4\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 13 Feb 2016 17:11:27 -0000\r
+\r
+No-one seemed opposed to C99 style loop variable declarations. The\r
+requirement to declare variables at the top of blocks is maybe a little\r
+more contested, but I believe it reflects the status quo.\r
+---\r
+ devel/STYLE | 7 ++++---\r
+ 1 file changed, 4 insertions(+), 3 deletions(-)\r
+\r
+diff --git a/devel/STYLE b/devel/STYLE\r
+index 24bd548..b22d8d3 100644\r
+--- a/devel/STYLE\r
++++ b/devel/STYLE\r
+@@ -25,9 +25,7 @@ The following nonsense code demonstrates many aspects of the style:\r
+ static some_type\r
+ function (param_type param, param_type param)\r
+ {\r
+-   int i;\r
+-\r
+-   for (i = 0; i < 10; i++) {\r
++   for (int i = 0; i < 10; i++) {\r
+        int j;\r
+ \r
+        j = i + 10;\r
+@@ -64,6 +62,9 @@ function (param_type param, param_type param)\r
+ * Code lines should be less than 80 columns and comments should be\r
+   wrapped at 70 columns.\r
+ \r
++* Variable declarations should be at the top of a block; C99 style\r
++  control variable declarations in for loops are also OK.\r
++\r
+ Naming\r
+ ------\r
+ \r
+-- \r
+2.6.4\r
+\r