Re: [PATCH 6/9] search for a reasonable gpg implementation

diff --git a/b7/7cd744ecce170b3108be6186c53e3f8e0d0fa2 b/b7/7cd744ecce170b3108be6186c53e3f8e0d0fa2
new file mode 100644 (file)
index 0000000..93dee38
--- /dev/null
+++ b/b7/7cd744ecce170b3108be6186c53e3f8e0d0fa2
@@ -0,0 +1,79 @@
+Return-Path: <jlmuir@imca-cat.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 458686DE0A9A\r
+ for <notmuch@notmuchmail.org>; Fri, 11 Dec 2015 14:18:56 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.158\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.158 tagged_above=-999 required=5 tests=[AWL=0.158]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id IXi6BKoj5Xrc for <notmuch@notmuchmail.org>;\r
+ Fri, 11 Dec 2015 14:18:54 -0800 (PST)\r
+Received: from tuna.imca.aps.anl.gov (tuna.imca.aps.anl.gov [164.54.200.33])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 5448B6DE005F\r
+ for <notmuch@notmuchmail.org>; Fri, 11 Dec 2015 14:18:54 -0800 (PST)\r
+Received: from mink.imca.aps.anl.gov (seal.imca.aps.anl.gov [164.54.200.39])\r
+ by tuna.imca.aps.anl.gov (Postfix) with ESMTP id 8FE512005F;\r
+ Fri, 11 Dec 2015 16:18:52 -0600 (CST)\r
+Subject: Re: [PATCH 6/9] search for a reasonable gpg implementation\r
+To: Tomi Ollila <tomi.ollila@iki.fi>,\r
+ Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+References: <1449718786-28000-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1449718786-28000-7-git-send-email-dkg@fifthhorseman.net>\r
+ <m24mfo7ioy.fsf@guru.guru-group.fi>\r
+From: "J. Lewis Muir" <jlmuir@imca-cat.org>\r
+Message-ID: <566B4BCC.7060203@imca-cat.org>\r
+Date: Fri, 11 Dec 2015 16:18:52 -0600\r
+MIME-Version: 1.0\r
+In-Reply-To: <m24mfo7ioy.fsf@guru.guru-group.fi>\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: 7bit\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 11 Dec 2015 22:18:56 -0000\r
+\r
+On 12/11/15 3:56 PM, Tomi Ollila wrote:\r
+>> +static const char*\r
+>> +_notmuch_database_get_gpg_path (notmuch_database_t *notmuch)\r
+>> +{\r
+>> +#define try_gpg_path(z) if (!access(z, X_OK)) return z\r
+>> +    try_gpg_path("/usr/bin/gpg2");\r
+>> +    try_gpg_path("/bin/gpg2");\r
+>> +    try_gpg_path("/usr/bin/gpg");\r
+>> +    try_gpg_path("/bin/gpg");\r
+>> +    return NULL;\r
+>> +}\r
+>\r
+> If this were to survive longer, BSD folks would like to have\r
+> /usr/local/bin checked...\r
+> (i don't know (yet) about os x\r
+\r
+I'm not following closely, but seeing paths to programs hard coded in\r
+the source never seems like a good idea; invariably someone will have\r
+the program in an unanticipated location.  I'm using pkgsrc on OS X,\r
+and my gpg is at /opt/pkg/bin/gpg.  How about a Notmuch configuration\r
+file item specifying the location of the program?  Or if not that, how\r
+about a configuration option at build time to specify the location of\r
+gpg that then gets hard coded in the source?  Or if not that, how about\r
+an environment variable that will specify the location of the program\r
+(e.g. like OpenSSH's SSH_ASKPASS environment variable)?\r
+\r
+Regards,\r
+\r
+Lewis\r