Re: [PATCH] use notmuch_database_open_verbose

diff --git a/08/a433cfb81f2e780551d27a22855fba23e5d9e5 b/08/a433cfb81f2e780551d27a22855fba23e5d9e5
new file mode 100644 (file)
index 0000000..1e91f87
--- /dev/null
+++ b/08/a433cfb81f2e780551d27a22855fba23e5d9e5
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 3D4896DE1890\r
+ for <notmuch@notmuchmail.org>; Sun, 13 Mar 2016 05:37:49 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.031\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.031 tagged_above=-999 required=5\r
+ tests=[AWL=-0.020, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Hu-HHXfKGqeT for <notmuch@notmuchmail.org>;\r
+ Sun, 13 Mar 2016 05:37:47 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 343B66DE188C\r
+ for <notmuch@notmuchmail.org>; Sun, 13 Mar 2016 05:37:47 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1af5Hn-0005hY-Fb; Sun, 13 Mar 2016 08:38:19 -0400\r
+Received: (nullmailer pid 16606 invoked by uid 1000);\r
+ Sun, 13 Mar 2016 12:37:40 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: patricktotzke@gmail.com\r
+Cc: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] use notmuch_database_open_verbose\r
+In-Reply-To:\r
+ <CAM7JpKmVzZYZ8bpjc5qzWvBedKx4GT-y+EKWS1KQgZJ_LamKNw@mail.gmail.com>\r
+References: <1457795857-12410-1-git-send-email-patricktotzke@gmail.com>\r
+ <87r3ff64sa.fsf@zancas.localnet> <87oaaj64gh.fsf@zancas.localnet>\r
+ <CAM7JpKmVzZYZ8bpjc5qzWvBedKx4GT-y+EKWS1KQgZJ_LamKNw@mail.gmail.com>\r
+User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 13 Mar 2016 09:37:40 -0300\r
+Message-ID: <87lh5m5zaj.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 Mar 2016 12:37:49 -0000\r
+\r
+Patrick Totzke <patricktotzke@gmail.com> writes:\r
+\r
+> As far as I understand the bindings, the returned message is not needed\r
+> because the return\r
+> value of `Database._open` (line 212) contains information about the type of\r
+> error that occurred.\r
+> This is passed on two lines below if the open-call was unsuccessful.\r
+>\r
+> The docstrings for this method are not ideal (the mentioned "status"\r
+> parameter is actually called "mode") but in terms of functionality it seems\r
+> ok.\r
+\r
+The error_message parameter (potentially) contains additional\r
+information about an error. In any case, you're passing one too few\r
+arguments to n_d_open_verbose, which doesn't seem like a good idea.\r
+\r
+d\r