Re: [PATCH] STYLE: Initial draft of coding style document

diff --git a/53/000b44ed06da4bb7329df606af32ce9739682b b/53/000b44ed06da4bb7329df606af32ce9739682b
new file mode 100644 (file)
index 0000000..600b42f
--- /dev/null
+++ b/53/000b44ed06da4bb7329df606af32ce9739682b
@@ -0,0 +1,107 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 92EB4431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Feb 2012 20:43:19 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id DwelkUysYqI4 for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Feb 2012 20:43:19 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
+       [18.9.25.15])\r
+       by olra.theworths.org (Postfix) with ESMTP id D3EA4431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Feb 2012 20:43:18 -0800 (PST)\r
+X-AuditID: 1209190f-b7f8a6d000000914-71-4f2f5a66ad73\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 14.94.02324.66A5F2F4; Sun,  5 Feb 2012 23:43:18 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q164hH0b028102; \r
+       Sun, 5 Feb 2012 23:43:17 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q164hFE5020298\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sun, 5 Feb 2012 23:43:16 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1RuGOz-0005iX-HL; Sun, 05 Feb 2012 23:42:05 -0500\r
+Date: Sun, 5 Feb 2012 23:42:05 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: David Bremner <bremner@debian.org>\r
+Subject: Re: [PATCH] STYLE: Initial draft of coding style document\r
+Message-ID: <20120206044205.GQ10898@mit.edu>\r
+References: <1327708018-1107-1-git-send-email-david@tethera.net>\r
+       <m2ehuhdzls.fsf@guru.guru-group.fi>\r
+       <CAB+hUn-o8JyWPqS+1e37m171cR04=LNOCBxFLyUiRK1vWjbe3g@mail.gmail.com>\r
+       <87vcnnjuac.fsf@rocinante.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87vcnnjuac.fsf@rocinante.cs.unb.ca>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsUixCmqrJsWpe9vsPSjuMXGZT+ZLZqmO1tc\r
+       vzmT2eLNynmsDiwev9rmMnsc/rqQxePW/dfsHs9W3WIOYInisklJzcksSy3St0vgyviydQNj\r
+       wQaOip53EQ2MB9m6GDk5JARMJF5dnM8CYYtJXLi3HiwuJLCPUeLoTc8uRi4gez2jxJxv3UwQ\r
+       zgkmiR03H7BAOEsYJeav3c4K0sIioCLx5Wo7mM0moCGxbf9yRhBbREBN4u6ydjCbWSBVYuvC\r
+       WexdjBwcwgJOEh0bs0HCvAI6EienHWWGmHmFUWL5++9MEAlBiZMzn7BA9GpJ3Pj3kgmkl1lA\r
+       WmL5Pw4Qk1PAUKLnXSJIhSjQBVNObmObwCg0C0nzLCTNsxCaFzAyr2KUTcmt0s1NzMwpTk3W\r
+       LU5OzMtLLdI10cvNLNFLTSndxAgOfEn+HYzfDiodYhTgYFTi4VUw0fcXYk0sK67MPcQoycGk\r
+       JMr7LAIoxJeUn1KZkVicEV9UmpNafIhRgoNZSYS3xh4ox5uSWFmVWpQPk5LmYFES51XTeucn\r
+       JJCeWJKanZpakFoEk5Xh4FCS4H0YCdQoWJSanlqRlplTgpBm4uAEGc4DNPwCSA1vcUFibnFm\r
+       OkT+FKOilDjvSZCEAEgiozQPrheWmF4xigO9IgzRzgNManDdr4AGMwEN3semCzK4JBEhJdXA\r
+       GHp8fk98g4VP/N0Hu7KnN0Rz2HyNMI8VMebzP6P7+FCUwO05pvuYrfUsDwRVS0lu+iT8NXTG\r
+       qb+102/Wnkp4fexyBf9rIfskaQu7ozMM/rt9ZbFzU54T8slqouoh5oLJ92ZynH938fgUla5r\r
+       bVcZbiv9u1L2xnFR2L1lTuq/Hq9lep9QOmHvSyWW4oxEQy3mouJEAIKr8r0nAwAA\r
+Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Feb 2012 04:43:19 -0000\r
+\r
+Quoth David Bremner on Feb 03 at  8:50 pm:\r
+> On Mon, 30 Jan 2012 18:01:15 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> > On Jan 30, 2012 4:38 PM, "Tomi Ollila" <tomi.ollila@iki.fi> wrote:\r
+> > >\r
+> > > > +\r
+> > > > +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8.\r
+> > > > +  Tabs should be only at the beginning of the line.\r
+> > >\r
+> > > So, after initial indentation (with tabs) there should not be further\r
+> > > tabs? We'll be using the former instead of the latter in these 2 below?\r
+> \r
+> Ah, I only meant to explain what whitespace-mode complains about, namely\r
+> \r
+> <space><space><space><space><tab>x=1;\r
+> \r
+> as opposed to \r
+> \r
+> <tab<space><space><space><space><tab>x=1;\r
+> \r
+> I'm not sure it's that important, but apparently if it stays in the\r
+> style guide it needs rewording.\r
+\r
+Any indentation style this difficult to explain can't be a good idea.\r
+How about,\r
+\r
+* Indent is 4 spaces with mixed tab/spaces and a tab width of 8.\r
+  (Specifically, a line should begin with zero or more tabs followed\r
+  by fewer than eight spaces.)\r