Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

diff --git a/70/6b9416422be47e44da66d8f84d17f0e04ea68f b/70/6b9416422be47e44da66d8f84d17f0e04ea68f
new file mode 100644 (file)
index 0000000..ca2fefe
--- /dev/null
+++ b/70/6b9416422be47e44da66d8f84d17f0e04ea68f
@@ -0,0 +1,100 @@
+Return-Path: <kfogel@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 012E7431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 11:18:35 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.699\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ZkhlBvtnOVzc for <notmuch@notmuchmail.org>;\r
+       Sat,  5 Jul 2014 11:18:27 -0700 (PDT)\r
+Received: from mail-yk0-f180.google.com (mail-yk0-f180.google.com\r
+       [209.85.160.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id DF1FF431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 11:18:26 -0700 (PDT)\r
+Received: by mail-yk0-f180.google.com with SMTP id 131so1084496ykp.39\r
+       for <notmuch@notmuchmail.org>; Sat, 05 Jul 2014 11:18:26 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to\r
+       :message-id:user-agent:mime-version:content-type;\r
+       bh=ZaHBGawieH2CY3uvXtQ0xHZCGYY4BRSt4HhwLJeUmFM=;\r
+       b=gE2efH3xZEzUQK7NOurHJzEABSPbqLQqh5NDQK0LkBLoN4HnqMJcIGsd8u0EZmC7rL\r
+       QY1a0XNR6Jxbw9QFjKGXJlAPILcRSIdJLiDExLNUGbPCOiekpl4bsGAzM9PSsfwMmH3F\r
+       H8xmnSifhqNIC+NwishAnZCYAWh974DOtYFFI6PaifURFYoSWnT+xThBEYDxiJFFRD9r\r
+       9S59W4j2uz9Q2TWYEPupO/a6ZMhMb4l/KTdkEGNOp+SnBdBcxCGQ2BNUIk6HD7VyDmIQ\r
+       VSZK4miPFrB7b2zwyuf0ETMrH6M4oJnYXNCq9WeMlNJyB/N7ltqNCbbbCHqfwVSNj2Nk\r
+       q+tA==\r
+X-Received: by 10.236.25.105 with SMTP id y69mr27170845yhy.33.1404584305188;\r
+       Sat, 05 Jul 2014 11:18:25 -0700 (PDT)\r
+Received: from floss.red-bean.com ([2602:30a:2ea0:cc50:8ea9:82ff:febf:1dce])\r
+       by mx.google.com with ESMTPSA id d44sm4648819yhh.13.2014.07.05.11.18.23\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sat, 05 Jul 2014 11:18:24 -0700 (PDT)\r
+Sender: Karl Fogel <kfogel@gmail.com>\r
+From: Karl Fogel <kfogel@red-bean.com>\r
+To: Sebastian Lipp <bacuh@riseup.net>\r
+Subject: Re: [PATCH] emacs: add missing paren to fix defun in\r
+       notmuch-address.el.\r
+References: <87wqsfik5l.fsf@floss.red-bean.com>\r
+       <87mwtah2hd.fsf@zancas.localnet> <877gkeau42.fsf@floss.red-bean.com>\r
+       <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
+       <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
+       <m2hajgxli5.fsf@guru.guru-group.fi> <87vc7vgbym.fsf@zancas.localnet>\r
+       <m2ehejykb1.fsf@guru.guru-group.fi>\r
+       <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+       <87oax6vt4u.fsf@ktab.red-bean.com>\r
+       <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+Date: Sat, 05 Jul 2014 13:18:22 -0500\r
+In-Reply-To:\r
+ <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+       (Sebastian Lipp's message of "Fri, 04 Jul 2014 11:25:38 +0200")\r
+Message-ID: <87d2djr7o1.fsf@floss.red-bean.com>\r
+User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+Reply-To: Karl Fogel <kfogel@red-bean.com>\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 Jul 2014 18:18:35 -0000\r
+\r
+Sebastian Lipp <bacuh@riseup.net> writes:\r
+>No, it happened by intention because what is "original" to you is not\r
+>part of my freshly cloned notmuch. So I thought good practise is to\r
+>construct *one* patch that brings the already fixed feature to the\r
+>notmuch codebase to keep it clean.\r
+>\r
+>If you like better, my next patch will only base Tomis and your\r
+>suggestions on top of the "original" patch.\r
+\r
+Oh, I had thought the changes were already in the notmuch tree.  Now I\r
+understand what you're saying, and yes, it makes sense.\r
+\r
+In general, supplying a log message with the patch with avoid such\r
+confusion.  If there is some prose expressing what the change is\r
+supposed to to, and giving any historical context (such as the mailing\r
+list thread starting from last year), then it will be easy for any\r
+reviewer to understand what the patch is intended to do, and check if it\r
+actually does that.\r
+\r
+Best,\r
+-Karl\r