--- /dev/null
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 9992A6DE13EF\r
+ for <notmuch@notmuchmail.org>; Wed, 28 Oct 2015 01:00:22 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.393\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.393 tagged_above=-999 required=5\r
+ tests=[AWL=-0.823, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,\r
+ DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01,\r
+ RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 5MvA-_LK0tAn for <notmuch@notmuchmail.org>;\r
+ Wed, 28 Oct 2015 01:00:20 -0700 (PDT)\r
+Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com\r
+ [209.85.212.180])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 858BD6DE0B44\r
+ for <notmuch@notmuchmail.org>; Wed, 28 Oct 2015 01:00:19 -0700 (PDT)\r
+Received: by wicll6 with SMTP id ll6so188737292wic.0\r
+ for <notmuch@notmuchmail.org>; Wed, 28 Oct 2015 01:00:17 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type;\r
+ bh=YETvpa/GYLvIHit0pS+LWi4FQ4SEw+vGZjJsdLXsz5A=;\r
+ b=Ecbt/CTb9azyPhaF/TYOjo+g7bninW1k46SLKeibwc5QClxsWg7riNy0Avj+Aaz5Ea\r
+ KkFy4bto+gwcCme3igybFwJ93cRaz/NMgV/j4ZP0Fh5qXwat0VMUYm9rulEaxx/jt83u\r
+ EO2LjJCzpELQ6R/kCrLaf96irNFu/rsM4ZGhmHq8ivCIChthg9TuMIm6p2Qbqba354Ae\r
+ I3/P0b/C5f+mq9mAcyR57rSPAPStiTamMFKpcpc6nY5vf5lDTyqOjlN1PHFHtHoOKS7s\r
+ hrWgGovsNL2cZxtX36aIfrjOntNAfgflUYjHdxTbey3p1Q4xfoTUhuySvZOW2Tj2N1if\r
+ 2HFA==\r
+X-Received: by 10.180.210.234 with SMTP id mx10mr1397018wic.31.1446019217719; \r
+ Wed, 28 Oct 2015 01:00:17 -0700 (PDT)\r
+Received: from localhost (188.30.196.178.threembb.co.uk. [188.30.196.178])\r
+ by smtp.gmail.com with ESMTPSA id jf13sm20404233wic.8.2015.10.28.01.00.13\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Wed, 28 Oct 2015 01:00:17 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Cc: tomi.ollila@iki.fi\r
+Subject: Re: [PATCH 3/4] emacs: add function to resend message to new\r
+ recipients\r
+In-Reply-To: <1441204482-26509-3-git-send-email-tomi.ollila@iki.fi>\r
+References: <1441204482-26509-1-git-send-email-tomi.ollila@iki.fi>\r
+ <1441204482-26509-3-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.18+469~gb743c48 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 28 Oct 2015 08:00:11 +0000\r
+Message-ID: <87pozza0dw.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 28 Oct 2015 08:00:22 -0000\r
+\r
+\r
+On Wed, 02 Sep 2015, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> The new function notmuch-show-message-resend re-sends\r
+> message to new recipients using #'message-resend.\r
+>\r
+> Recipients are read from minibuffer as a comma-separated\r
+> string (with some keyboard support including tab completion).\r
+>\r
+> Final confirmation before sending is asked.\r
+> ---\r
+\r
+This series looks good to me modulo three minor comments (I even\r
+like the choice of binding to b). \r
+\r
+The first comment is that, in light of the recent address series, I\r
+think Patch 2 can be dropped completely, with a small change to this\r
+patch. See below for that, and the other two minor suggestions.\r
+\r
+Also, I wonder if when it gets a NEWS item it might be worth mentioning\r
+that a user might have already added this function to their emacs init\r
+file as it has been on the wiki. (It took me way too long to realise\r
+that was why this patch was not working for me!)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+>\r
+> Since id:1440619626-18768-2-git-send-email-tomi.ollila@iki.fi\r
+> - changed (bury-buffer) to (notmuch-bury-or-kill-this-buffer)\r
+> - it is hard to have the buffer been kept around but it is posiible\r
+>\r
+> emacs/notmuch-address.el | 19 +++++++++++++++++++\r
+> emacs/notmuch-show.el | 8 ++++++++\r
+> 2 files changed, 27 insertions(+)\r
+>\r
+> diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el\r
+> index 8982a415ce11..83788efd3c1b 100644\r
+> --- a/emacs/notmuch-address.el\r
+> +++ b/emacs/notmuch-address.el\r
+> @@ -119,4 +119,23 @@ (defun notmuch-address-locate-command (command)\r
+> \r
+> ;;\r
+> \r
+> +(defun notmuch-address-from-minibuffer (prompt)\r
+> + (if (not (notmuch-address--message-insinuated))\r
+> + (read-string prompt)\r
+\r
+This can become \r
+ (if (not notmuch-address-command)\r
+ \r
+> + (let ((rmap (copy-keymap minibuffer-local-map))\r
+> + (omap minibuffer-local-map))\r
+> + ;; Configure TAB to start completion when executing read-string.\r
+> + ;; "Original" minibuffer keymap is restored just before calling\r
+> + ;; notmuch-address-expand-name as it may also use minibuffer-local-map\r
+> + ;; (completing-read probably does not but if something else is used there).\r
+> + (define-key rmap "\C-i" (lambda () ;; TAB\r
+\r
+I think this could become (define-key rmap (kbd "TAB") (lambda () ....\r
+\r
+which is easy to read and consistent with the definitions of other\r
+keymaps (eg the main notmuch-show keymap).\r
+\r
+> + (interactive)\r
+> + (let ((enable-recursive-minibuffers t)\r
+> + (minibuffer-local-map omap))\r
+> + (notmuch-address-expand-name))))\r
+> + (let ((minibuffer-local-map rmap))\r
+> + (read-string prompt)))))\r
+> +\r
+> +;;\r
+> +\r
+> (provide 'notmuch-address)\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 0565ab0725b2..046cb0e41f0b 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1806,6 +1806,14 @@ (defun notmuch-show-forward-message (&optional prompt-for-sender)\r
+> (with-current-notmuch-show-message\r
+> (notmuch-mua-new-forward-message prompt-for-sender)))\r
+> \r
+> +(defun notmuch-show-resend-message (addresses)\r
+> + "Resend the current message."\r
+> + (interactive (list (notmuch-address-from-minibuffer "Resend to: ")))\r
+> + (when (yes-or-no-p (concat "Confirm resend to " addresses " "))\r
+\r
+Perhaps y-or-n-p rather than yes-or-no-p?\r
+ \r
+> + (notmuch-show-view-raw-message)\r
+> + (message-resend addresses)\r
+> + (notmuch-bury-or-kill-this-buffer)))\r
+> +\r
+> (defun notmuch-show-next-message (&optional pop-at-end)\r
+> "Show the next message.\r
+> \r
+> -- \r
+> 2.0.0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff