Re: [Patch v2 1/2] emacs: show: document the mark unread defcustom function

diff --git a/3e/af1df3c3293e6fe8ad6f6a4d0987f5ce155b10 b/3e/af1df3c3293e6fe8ad6f6a4d0987f5ce155b10
new file mode 100644 (file)
index 0000000..ebee0df
--- /dev/null
+++ b/3e/af1df3c3293e6fe8ad6f6a4d0987f5ce155b10
@@ -0,0 +1,99 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4DE72431FBC\r
+       for <notmuch@notmuchmail.org>; Mon,  8 Sep 2014 09:10:49 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id PB+2lSPtqlNv for <notmuch@notmuchmail.org>;\r
+       Mon,  8 Sep 2014 09:10:43 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id C9234431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  8 Sep 2014 09:10:42 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id CDFA410008C;\r
+       Mon,  8 Sep 2014 19:10:25 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 1/2] emacs: show: document the mark unread\r
+       defcustom       function\r
+In-Reply-To: <1410020531-24419-2-git-send-email-markwalters1009@gmail.com>\r
+References: <1410020531-24419-1-git-send-email-markwalters1009@gmail.com>\r
+       <1410020531-24419-2-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.18.1+93~gaa65b5d (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 08 Sep 2014 19:10:25 +0300\r
+Message-ID: <m24mwihz4e.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 08 Sep 2014 16:10:49 -0000\r
+\r
+On Sat, Sep 06 2014, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> ---\r
+>  emacs/notmuch-show.el |    8 +++++++-\r
+>  1 file changed, 7 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 7549fbb..5695d95 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -224,7 +224,13 @@ For example, if you wanted to remove an \"unread\" tag and add a\r
+>    :group 'notmuch-show)\r
+>  \r
+>  (defcustom notmuch-show-mark-read-function #'notmuch-show-seen-current-message\r
+> -  "Function to control which messages are marked read."\r
+> +  "Function to control which messages are marked read.\r
+> +\r
+> +The function should take two arguments START and END which will\r
+> +be the start and end of the visible portion of the buffer and\r
+> +should mark the appropriate messages read by applying\r
+> +`notmuch-show-mark-read'. This function will be called after\r
+> +every user interaction with notmuch."\r
+\r
+This patch LGTM. Now that we know more I would have liked this function\r
+would not take the START & END parameters but the function itself could\r
+have done (window-start) (window-end) if it so desires...\r
+\r
+... as we have discussed in IRC my current version uses (point) in place\r
+of END (window-end) and I may drop START too (while investigating Mark's\r
+IRC-given suggestions).\r
+\r
+Anyway, the ship may have sailed and therefore I am inclined to give +1\r
+to this patch...\r
+\r
+Tomi\r
+\r
+\r
+>    :type 'function\r
+>    :group 'notmuch-show)\r
+>  \r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r