Optimise the no-op post-commit hook in the web edit case by skipping loading plugins...

diff --git a/debian/changelog b/debian/changelog
index dfc754d65b76721f3081eaaa63800b7bfc7b2d0a..49bd854475815387e05f5b8d608711e1c7919d00 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -31,6 +31,8 @@ ikiwiki (2.68) UNRELEASED; urgency=low
   * external: RPC functions can be injected to replace exported functions.
   * Updated Spanish translation from the ever vigilant Victor Moral.
   * Updated Danish translation from Jonas Smedegaard. Closes: #503117
+  * Optimise the no-op post-commit hook in the web edit case by skipping
+    loading plugins. (Particularly a win when using external plugins.)
 
  -- Joey Hess <joeyh@debian.org>  Fri, 17 Oct 2008 20:11:02 -0400
 

diff --git a/ikiwiki.in b/ikiwiki.in
index 4f24cfc2eb8ae4c53d7c0f471fbf12aea13c0578..fd21b49112527343c6f63e9eae88f7506a9eb134 100755 (executable)
--- a/ikiwiki.in
+++ b/ikiwiki.in
@@ -118,6 +118,12 @@ sub getconfig () { #{{{
                        error("WRAPPED_OPTIONS: $@");
                }
                delete $ENV{WRAPPED_OPTIONS};
+
+               # optimisation for no-op post_commit 
+               if ($config{post_commit} && ! commit_hook_enabled()) {
+                       exit 0;
+               }
+
                loadplugins();
                checkconfig();
        }