Re: [Patch v5 05/11] lib: provide config API

diff --git a/5e/2591d6468f10a03beed0fab85f346e56ab9d05 b/5e/2591d6468f10a03beed0fab85f346e56ab9d05
new file mode 100644 (file)
index 0000000..1e02dce
--- /dev/null
+++ b/5e/2591d6468f10a03beed0fab85f346e56ab9d05
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id C86EF6DE01F7\r
+ for <notmuch@notmuchmail.org>; Tue, 24 May 2016 04:48:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.012\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.012 tagged_above=-999 required=5\r
+ tests=[AWL=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 6hDp1n13h77o for <notmuch@notmuchmail.org>;\r
+ Tue, 24 May 2016 04:48:16 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id ED5CB6DE00C6\r
+ for <notmuch@notmuchmail.org>; Tue, 24 May 2016 04:48:15 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1b5Aoe-0004EV-IF; Tue, 24 May 2016 07:48:04 -0400\r
+Received: (nullmailer pid 21715 invoked by uid 1000);\r
+ Tue, 24 May 2016 11:48:11 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [Patch v5 05/11] lib: provide config API\r
+In-Reply-To: <1463135893-7471-6-git-send-email-david@tethera.net>\r
+References: <1463135893-7471-1-git-send-email-david@tethera.net>\r
+ <1463135893-7471-6-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.22+15~g1aa6f90 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 24 May 2016 08:48:11 -0300\r
+Message-ID: <87iny3n0ck.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 24 May 2016 11:48:23 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+> +    notmuch->exception_reported = TRUE;\r
+> +    if (! notmuch->exception_reported) {\r
+> +        _notmuch_database_log (notmuch, "Error: A Xapian exception occurred setting metadata: %s\n",\r
+> +                               error.get_msg().c_str());\r
+> +    }\r
+\r
+Upon revisiting, this looks pretty silly. According to the commit\r
+message in e2341cb the point of exception_reported is to avoid excess\r
+error reporting when closing/flushing after another error. Since we\r
+don't actually print these error messages anymore, I'm not sure it's\r
+even needed.  In any case, this is a bad case of copy-pasta, which I've\r
+fixed in git by removing the if (in both places).\r
+\r