Re: [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag)

diff --git a/0f/6fcdaad4f7c8d313a5d79bee9781fffac21933 b/0f/6fcdaad4f7c8d313a5d79bee9781fffac21933
new file mode 100644 (file)
index 0000000..1f7ca7f
--- /dev/null
+++ b/0f/6fcdaad4f7c8d313a5d79bee9781fffac21933
@@ -0,0 +1,96 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 45E3E431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  5 Apr 2012 19:24:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id L3PlHmwNuVtH for <notmuch@notmuchmail.org>;\r
+       Thu,  5 Apr 2012 19:24:39 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+       [18.9.25.13])\r
+       by olra.theworths.org (Postfix) with ESMTP id B0F43431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  5 Apr 2012 19:24:39 -0700 (PDT)\r
+X-AuditID: 1209190d-b7fbf6d0000008ba-b4-4f7e53e780e5\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 84.C0.02234.7E35E7F4; Thu,  5 Apr 2012 22:24:39 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q362Oc4M010151; \r
+       Thu, 5 Apr 2012 22:24:39 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q362ObRI026334\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Thu, 5 Apr 2012 22:24:38 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SFyqq-0004x3-S0; Thu, 05 Apr 2012 22:24:37 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag)\r
+In-Reply-To: <1333234442-28616-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1333234442-28616-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.12+107~gf2d67c3 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Thu, 05 Apr 2012 22:24:36 -0400\r
+Message-ID: <87lim97g2j.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsUixG6nrvs8uM7f4EWHkMXquTwW12/OZHZg\r
+       8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4MtqaLjIXNLFVLJ08k7WB8R1LFyMnh4SAicS1\r
+       addZIWwxiQv31rN1MXJxCAnsY5T4PWEBM4SznlHi+qzXLBDOCSaJp/t2QpUtYZSYtek42Cw2\r
+       AQ2JbfuXM4LYIgKuEk+/fWYGsYUFfCQOvf8KFucU8JL4ceUaO4gtJOApsenRZrBeUYF4iXUN\r
+       78HuYBFQlXjZv58NxOYFum9nywYmCFtQ4uTMJ2D1zAJaEjf+vWSawCgwC0lqFpLUAkamVYyy\r
+       KblVurmJmTnFqcm6xcmJeXmpRbpGermZJXqpKaWbGEEhySnJu4Px3UGlQ4wCHIxKPLwnt9b6\r
+       C7EmlhVX5h5ilORgUhLlPR9U5y/El5SfUpmRWJwRX1Sak1p8iFGCg1lJhDfcAyjHm5JYWZVa\r
+       lA+TkuZgURLnVdV65yckkJ5YkpqdmlqQWgSTleHgUJLgnQkyVLAoNT21Ii0zpwQhzcTBCTKc\r
+       B2i4aTDI8OKCxNzizHSI/ClGRSlxXg6QhABIIqM0D64XljJeMYoDvSLMqwNSxQNMN3Ddr4AG\r
+       MwENPvm1GmRwSSJCSqqB0XOVwJYtZwKOXyk9++epjYvYtdhtLzkOu77+5Faz7uLJha6cbHEa\r
+       j/yK7u/sEX7bZmK68Khnxuyq//sDb/48n3dnl2r3n0vXdB5XSQc+XtdiWuc4k6HeSyXF2/Wx\r
+       6pz+aK79OzXcgo8vFJ360n3WUY6H2Tazky5n+arxtQrkz33vvTbz36/7H5RYijMSDbWYi4oT\r
+       AVj7Koj0AgAA\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 06 Apr 2012 02:24:40 -0000\r
+\r
+On Sat, 31 Mar 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> This is version 2 of the exclude= series (version 1 is [1]).\r
+>\r
+> The main changes are the addition of some systematic notmuch-search\r
+> tests for all the exclude options, and I no longer add the\r
+> exclude=flag option to notmuch-show.c (the output was too similar to\r
+> exclude=false to be worth keeping).\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+> id:"1331836925-31437-1-git-send-email-markwalters1009@gmail.com".\r
+\r
+Sorry for the slow review.  Besides my fairly superficial comments,\r
+everything else LGTM.\r
+\r
+It's great to see exclude really turning into a robust feature!  I had\r
+no idea the path would be this long when I wrote that original little\r
+hack.  I'm thankful you're sticking with it.\r