Re: [PATCH v5 0/6] emacs: show: lazy handling of hidden parts

diff --git a/bf/984b0a3ad67f310cca59415976071c08fb72be b/bf/984b0a3ad67f310cca59415976071c08fb72be
new file mode 100644 (file)
index 0000000..86ec812
--- /dev/null
+++ b/bf/984b0a3ad67f310cca59415976071c08fb72be
@@ -0,0 +1,101 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 17BED431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 22:07:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id LAWk8kqHe7hX for <notmuch@notmuchmail.org>;\r
+       Sun,  9 Jun 2013 22:07:39 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu\r
+       [18.9.25.14])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8890B431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 22:07:39 -0700 (PDT)\r
+X-AuditID: 1209190e-b7fa46d000006e53-1b-51b55f1b886b\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id F8.49.28243.B1F55B15; Mon, 10 Jun 2013 01:07:39 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r5A57baJ027350; \r
+       Mon, 10 Jun 2013 01:07:38 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5A57Z91030903\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Mon, 10 Jun 2013 01:07:36 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1UluKN-0006tt-5O; Mon, 10 Jun 2013 01:07:35 -0400\r
+Date: Mon, 10 Jun 2013 01:07:34 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH v5 0/6] emacs: show: lazy handling of hidden parts\r
+Message-ID: <20130610050734.GD22196@mit.edu>\r
+References: <1370840233-23258-1-git-send-email-markwalters1009@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1370840233-23258-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hTV1pWO3xpoMG0hl8XquTwW12/OZHZg\r
+       8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Mo4v3cle0M9esW3fd7YGxgusXYycHBICJhJ9\r
+       C5rYIWwxiQv31rN1MXJxCAnsY5ToefKWHcLZyCix8dJHqMxpJolZ3z8wQzhLGCUa1j9kA+ln\r
+       EVCVeLj2PAuIzSagIbFt/3JGEFtEQEfi9qEFYDuYBaQlvv1uZgKxhQXcJL68egRWwwtUc2np\r
+       BLA5QgKeEj//7mKHiAtKnJz5hAWiV0vixr+XQL0cYHOW/+MACXMKeEnsWN4LViIqoCIx5eQ2\r
+       tgmMQrOQdM9C0j0LoXsBI/MqRtmU3Crd3MTMnOLUZN3i5MS8vNQiXWO93MwSvdSU0k2M4LCW\r
+       5NvB+PWg0iFGAQ5GJR7eB7+2BAqxJpYVV+YeYpTkYFIS5d0ZtTVQiC8pP6UyI7E4I76oNCe1\r
+       +BCjBAezkgjvT0ugHG9KYmVValE+TEqag0VJnPdKyk1/IYH0xJLU7NTUgtQimKwMB4eSBG94\r
+       HFCjYFFqempFWmZOCUKaiYMTZDgP0HAjkBre4oLE3OLMdIj8KUZFKXFePZCEAEgiozQPrheW\r
+       dl4xigO9IsxrDlLFA0xZcN2vgAYzAQ2eor4FZHBJIkJKqoExSfV58LUFS2b8fr5dtdpi/moJ\r
+       AUOZxXqbV24+c3X7LSumh1MNuarFFS5v3XSx3tTr1T19PcWoxcZ31geGfc09nf63Zm7UkQU3\r
+       pUWmLZiUfOz1rM0nvs7ZYf4p2mga5+NFdTxcJrnuCt/Md59+wP/5h+VE3gD9+wEbuq/FH3I2\r
+       OdD6orjSTG2isBJLcUaioRZzUXEiAM72ZkkWAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 10 Jun 2013 05:07:47 -0000\r
+\r
+LGTM.\r
+\r
+Quoth Mark Walters on Jun 10 at  5:57 am:\r
+> This is version 5 of this patch set. Version 4 is at\r
+> id:1370074547-24677-1-git-send-email-markwalters1009@gmail.com.\r
+> \r
+> This version fixes the two bugs pointed out in Austin's review\r
+> id:20130610023952.GC22196@mit.edu.\r
+> \r
+> I decided to add the :notmuch-part text property separately from\r
+> create-overlays as they have slightly different regions (one includes\r
+> the button one does not) and are applied at slightly different times\r
+> (we do not create overlays for lazy parts).\r
+> \r
+> I was not sure whether we created two overlays for hidden lazy parts\r
+> in v4 (it might not have done as the part was empty and we do not\r
+> create overlays for empty parts) but that is stupidly fragile. Thus we\r
+> explicitly do not create overlays for lazy parts until they are\r
+> inserted.\r
+> \r
+> The diff from v4 is below.\r
+> \r
+> Best wishes\r
+> \r
+> Mark\r