[PATCH] patchformatting: Test Suite Enhancements

diff --git a/bd/8b5028b501644e967d447d5bf1c80471b2b2f9 b/bd/8b5028b501644e967d447d5bf1c80471b2b2f9
new file mode 100644 (file)
index 0000000..59c061a
--- /dev/null
+++ b/bd/8b5028b501644e967d447d5bf1c80471b2b2f9
@@ -0,0 +1,97 @@
+Return-Path: <thomas@schwinge.name>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3F9F9431FD0\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Sep 2011 11:25:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id p5Ot73H4gxIr for <notmuch@notmuchmail.org>;\r
+       Thu, 29 Sep 2011 11:25:39 -0700 (PDT)\r
+Received: from smtprelay04.ispgateway.de (smtprelay04.ispgateway.de\r
+       [80.67.31.27])\r
+       by olra.theworths.org (Postfix) with ESMTP id 820F4431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Sep 2011 11:25:39 -0700 (PDT)\r
+Received: from [87.180.87.168] (helo=stokes.schwinge.homeip.net)\r
+       by smtprelay04.ispgateway.de with esmtpa (Exim 4.68)\r
+       (envelope-from <thomas@schwinge.name>) id 1R9LHn-0003cA-4q\r
+       for notmuch@notmuchmail.org; Thu, 29 Sep 2011 20:24:43 +0200\r
+Received: (qmail 25126 invoked from network); 29 Sep 2011 18:24:14 -0000\r
+Received: from boole.schwinge.homeip.net (192.168.111.208)\r
+       by stokes.schwinge.homeip.net with QMQP; 29 Sep 2011 18:24:14 -0000\r
+Received: (nullmailer pid 15103 invoked by uid 1000);\r
+       Thu, 29 Sep 2011 18:24:14 -0000\r
+From: Thomas Schwinge <thomas@schwinge.name>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] patchformatting: Test Suite Enhancements\r
+Date: Thu, 29 Sep 2011 20:24:05 +0200\r
+Message-Id: <1317320646-15062-1-git-send-email-thomas@schwinge.name>\r
+X-Mailer: git-send-email 1.7.6.3\r
+In-Reply-To: <87boutee61.fsf@servo.factory.finestructure.net>\r
+References: <87boutee61.fsf@servo.factory.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=UTF-8\r
+Content-Transfer-Encoding: 8bit\r
+X-Df-Sender: dGhvbWFzQHNjaHdpbmdlLm5hbWU=\r
+Cc: Thomas Schwinge <thomas@schwinge.name>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 29 Sep 2011 18:25:40 -0000\r
+\r
+Based on the emails starting at\r
+id:"87liu2kcq6.fsf@servo.factory.finestructure.net".\r
+---\r
+\r
+Hi!\r
+\r
+I applied the attached patch, based on this thread's discussion.\r
+\r
+\r
+Grüße,\r
+ Thomas\r
+\r
+\r
+---\r
+ patchformatting.mdwn |   10 ++++++++++\r
+ 1 files changed, 10 insertions(+), 0 deletions(-)\r
+\r
+diff --git a/patchformatting.mdwn b/patchformatting.mdwn\r
+index cf5bf81..914371d 100644\r
+--- a/patchformatting.mdwn\r
++++ b/patchformatting.mdwn\r
+@@ -41,6 +41,16 @@ Eric S. Raymond has written good\r
+ [Software Release Practice HOWTO](http://tldp.org/HOWTO/Software-Release-Practice-HOWTO/).\r
+ Check what he has to say about this issue. \r
+ \r
++### Test Suite Enhancements\r
++\r
++New features as well as bug fixes should typically come with test suite\r
++enhancements.  The test suite changes should be done first (tagged as *expected\r
++to fail*), and the feature implementation or bug fix should come second\r
++(removing the *expected to fail* tag).  This way, the test suite specifies the\r
++behavior you're trying to implement, be it a new feature or a bug fix.  By\r
++defining beforehand exactly what you expect to happen, everyone can confirm\r
++that your patch achieves what it is meant it to.\r
++\r
+ ## Prepare patches for e-mail submission\r
+ \r
+ If you've made just one commit (containing just one bugfix or new feature)\r
+-- \r
+1.7.6.3\r
+\r