Re: notmuch sha1 implementation broken on (some) big-endian architectures

diff --git a/28/0f92a7c51b4351d045d417cc801a25cb0ad542 b/28/0f92a7c51b4351d045d417cc801a25cb0ad542
new file mode 100644 (file)
index 0000000..b806685
--- /dev/null
+++ b/28/0f92a7c51b4351d045d417cc801a25cb0ad542
@@ -0,0 +1,105 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 09E6D431FDF\r
+       for <notmuch@notmuchmail.org>; Sun, 24 Nov 2013 08:43:04 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id dpsQUGyQC-+m for <notmuch@notmuchmail.org>;\r
+       Sun, 24 Nov 2013 08:42:56 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 66466431FDD\r
+       for <notmuch@notmuchmail.org>; Sun, 24 Nov 2013 08:42:56 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id CB64A10005E;\r
+       Sun, 24 Nov 2013 18:42:46 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: notmuch sha1 implementation broken on (some) big-endian\r
+       architectures\r
+In-Reply-To: <87eh666mhp.fsf@zancas.localnet>\r
+References: <87eh666mhp.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.16+175~g19e97d6 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 24 Nov 2013 18:42:46 +0200\r
+Message-ID: <m2ob593g55.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 24 Nov 2013 16:43:04 -0000\r
+\r
+On Sun, Nov 24 2013, David Bremner <david@tethera.net> wrote:\r
+\r
+> The following code, when linked with libnotmuch.a and libutil.a does a\r
+> passable imitation of sha1sum on amd64 (and I guess also i386) but\r
+> computes a different digest on powerpc and probably sparc and s390x.\r
+>\r
+> In the long run we should maybe outsource hash computations to\r
+> e.g. librhash, but I'd like a simpler fix for 0.17, if possible\r
+>\r
+> P.S. I blame Austin for adding the "missing-headers" test which found\r
+> this bug ;).\r
+\r
+This is interesting problem, I would have guessed that this would\r
+fails on LITTLE_ENDIAN machines easier, if ever...\r
+\r
+... especially as there is line\r
+\r
+lib/libsha1.c:52:#if (PLATFORM_BYTE_ORDER == IS_LITTLE_ENDIAN)\r
+\r
+... but...\r
+\r
+I could not find any (other) matches for PLATFORM_BYTE_ORDER nor\r
+IS_LITTLE_ENDIAN in source code or in /usr/include/**/*.h or\r
+in /usr/lib/gcc/**/*.h\r
+\r
+I did some testing and it seems that \r
+#if (FOOOO == BBBAAARRR)\r
+<code>\r
+#endif\r
+\r
+will have <code> in output file in case neither of the above are\r
+defined... :/\r
+\r
+So, this could work:\r
+\r
+#if <endian.h>  // for BYTE_ORDER && LITTLE_ENDIAN\r
+\r
+and then\r
+\r
+#if (BYTE_ORDER == LITTLE_ENDIAN)\r
+...\r
+\r
+to replace lib/libsha1.c:53 (53 now after endian.h added)\r
+\r
+\r
+Please test on BIG_ENDIAN machine...\r
+\r
+\r
+In case this works, then we'd need to inform users that their\r
+long/missing Message ID:s are now coded differently in their\r
+databases...\r
+\r
+\r
+Tomi\r