--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2D250429E32\r
+ for <notmuch@notmuchmail.org>; Fri, 2 May 2014 07:12:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.502\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.502 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id TXoWjV+BTdKg for <notmuch@notmuchmail.org>;\r
+ Fri, 2 May 2014 07:12:05 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 8C5A7429E28\r
+ for <notmuch@notmuchmail.org>; Fri, 2 May 2014 07:12:05 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1WgEC1-0008B8-3q; Fri, 02 May 2014 15:12:03 +0100\r
+Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1WgEC0-0004k7-IJ; Fri, 02 May 2014 15:12:00 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: allow functions in\r
+ notmuch-show-stash-mlarchive-link-alist\r
+In-Reply-To: <1398947711-12658-1-git-send-email-jani@nikula.org>\r
+References: <874n1cbfyi.fsf@qmul.ac.uk>\r
+ <1398947711-12658-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 02 May 2014 15:11:59 +0100\r
+Message-ID: <87mwf09snk.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 87.81.223.162\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: b19d7b63756c8108ddef355123d34352 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.1 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 02 May 2014 14:12:10 -0000\r
+\r
+\r
+This version LGTM +1.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+On Thu, 01 May 2014, Jani Nikula <jani@nikula.org> wrote:\r
+> Some archives may use a more complicated scheme for referring to\r
+> messages than just concatenated url and message-id. In particular,\r
+> patchwork requires a query to translate message-id to a patchwork\r
+> patch id. Allow functions in notmuch-show-stash-mlarchive-link-alist\r
+> to facilitate this.\r
+>\r
+> For example, one could use something like this for patchwork.\r
+>\r
+> (lambda (message-id)\r
+> (concat\r
+> "http://patchwork.example.com/patch/"\r
+> (nth 0\r
+> (split-string\r
+> (car (last (process-lines "pwclient" "search" "-n" "1"\r
+> "-m" (concat "<" message-id ">"))))))))\r
+> ---\r
+> emacs/notmuch-show.el | 40 +++++++++++++++++++++++++++-------------\r
+> 1 file changed, 27 insertions(+), 13 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index df10d4bad93b..10fc872141dc 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -180,10 +180,21 @@ each attachment handler is logged in buffers with names beginning\r
+> )\r
+> "List of Mailing List Archives to use when stashing links.\r
+> \r
+> -These URIs are concatenated with the current message's\r
+> -Message-Id in `notmuch-show-stash-mlarchive-link'."\r
+> +This list is used for generating a Mailing List Archive reference\r
+> +URI with the current message's Message-Id in\r
+> +`notmuch-show-stash-mlarchive-link'.\r
+> +\r
+> +If the cdr of the alist element is not a function, the cdr is\r
+> +expected to contain a URI that is concatenated with the current\r
+> +message's Message-Id to create a ML archive reference URI.\r
+> +\r
+> +If the cdr is a function, the function is called with the\r
+> +Message-Id as the argument, and the function is expected to\r
+> +return the ML archive reference URI."\r
+> :type '(alist :key-type (string :tag "Name")\r
+> - :value-type (string :tag "URL"))\r
+> + :value-type (choice\r
+> + (string :tag "URL")\r
+> + (function :tag "Function returning the URL")))\r
+> :group 'notmuch-show)\r
+> \r
+> (defcustom notmuch-show-stash-mlarchive-link-default "Gmane"\r
+> @@ -2055,16 +2066,19 @@ This presumes that the message is available at the selected Mailing List Archive\r
+> If optional argument MLA is non-nil, use the provided key instead of prompting\r
+> the user (see `notmuch-show-stash-mlarchive-link-alist')."\r
+> (interactive)\r
+> - (notmuch-common-do-stash\r
+> - (concat (cdr (assoc\r
+> - (or mla\r
+> - (let ((completion-ignore-case t))\r
+> - (completing-read\r
+> - "Mailing List Archive: "\r
+> - notmuch-show-stash-mlarchive-link-alist\r
+> - nil t nil nil notmuch-show-stash-mlarchive-link-default)))\r
+> - notmuch-show-stash-mlarchive-link-alist))\r
+> - (notmuch-show-get-message-id t))))\r
+> + (let ((url (cdr (assoc\r
+> + (or mla\r
+> + (let ((completion-ignore-case t))\r
+> + (completing-read\r
+> + "Mailing List Archive: "\r
+> + notmuch-show-stash-mlarchive-link-alist\r
+> + nil t nil nil\r
+> + notmuch-show-stash-mlarchive-link-default)))\r
+> + notmuch-show-stash-mlarchive-link-alist))))\r
+> + (notmuch-common-do-stash\r
+> + (if (functionp url)\r
+> + (funcall url (notmuch-show-get-message-id t))\r
+> + (concat url (notmuch-show-get-message-id t))))))\r
+> \r
+> (defun notmuch-show-stash-mlarchive-link-and-go (&optional mla)\r
+> "Copy an ML Archive URI for the current message to the kill-ring and visit it.\r
+> -- \r
+> 1.9.2\r
projects / notmuch-archives.git / commitdiff