Re: [Patch v6 4/8] lib: add "verbose" versions of notmuch_database_{open,create}

diff --git a/05/fcf35b57c6d7ed589a0a6f35b8e1dd1ccec2d7 b/05/fcf35b57c6d7ed589a0a6f35b8e1dd1ccec2d7
new file mode 100644 (file)
index 0000000..53714c2
--- /dev/null
+++ b/05/fcf35b57c6d7ed589a0a6f35b8e1dd1ccec2d7
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id AEF4C431FC2\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Mar 2015 16:47:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id msrHesNwSijV for <notmuch@notmuchmail.org>;\r
+       Sat, 28 Mar 2015 16:47:34 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6BD67431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 28 Mar 2015 16:47:34 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.80) (envelope-from <david@tethera.net>)\r
+       id 1Yc0R0-0006uz-3b; Sat, 28 Mar 2015 23:46:34 +0000\r
+Received: (nullmailer pid 7463 invoked by uid 1000); Sat, 28 Mar 2015\r
+       23:46:20 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v6 4/8] lib: add "verbose" versions of\r
+       notmuch_database_{open,create}\r
+In-Reply-To: <m2oandigk9.fsf@guru.guru-group.fi>\r
+References: <1427494320-1483-1-git-send-email-david@tethera.net>\r
+       <1427494320-1483-5-git-send-email-david@tethera.net>\r
+       <m2oandigk9.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.19+86~gbed8b67 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 29 Mar 2015 00:46:20 +0100\r
+Message-ID: <87twx4ptwz.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 28 Mar 2015 23:47:37 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+>\r
+> Just that this small piece of code above git pass my sparse sieve, perhaps\r
+> this could be amended to:\r
+>\r
+>     if (message) {\r
+>         if (status_string)\r
+>             *status_string = message;\r
+>         else \r
+>             free(message);\r
+>     }\r
+>\r
+\r
+I amended and pushed. Thanks for all the reviewing.\r
+\r
+d\r