Add upstream.workaround warning for addpredict calls. Thanks to

Diego Pettenò <flameeyes@g.o> for the suggestion.

diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 07f1deadeda0f92ced8387050ca4b50ce2762170..ed30795744e52050088719ec6d81d97f9d667e70 100644 (file)
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -448,6 +448,12 @@ class PreserveOldLib(LineCheck):
        re = re.compile(r'.*preserve_old_lib')
        error = errors.PRESERVE_OLD_LIB
 
+class SandboxAddpredict(LineCheck):
+       """Check for calls to the addpredict function."""
+       repoman_check_name = 'upstream.workaround'
+       re = re.compile(r'(^|\s)addpredict\b')
+       error = errors.SANDBOX_ADDPREDICT
+
 class DeprecatedBindnowFlags(LineCheck):
        """Check for calls to the deprecated bindnow-flags function."""
        repoman_check_name = 'ebuild.minorsyn'
@@ -553,7 +559,7 @@ _constant_checks = tuple((c() for c in (
        DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue,
        SrcCompileEconf, Eapi3DeprecatedFuncs,
        Eapi4IncompatibleFuncs, Eapi4GoneVars, BuiltWithUse,
-       PreserveOldLib)))
+       PreserveOldLib, SandboxAddpredict)))
 
 _here_doc_re = re.compile(r'.*\s<<[-]?(\w+)$')
 

diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py
index 8a28d4fd7b7aad26439539d695681d3ab0f2b042..5ad6be31fcfbae44b429477ec32aff6cf6292b68 100644 (file)
--- a/pym/repoman/errors.py
+++ b/pym/repoman/errors.py
@@ -1,5 +1,5 @@
 # repoman: Error Messages
-# Copyright 2007 Gentoo Foundation
+# Copyright 2007-2010 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 
 COPYRIGHT_ERROR = 'Invalid Gentoo Copyright on line: %d'
@@ -20,3 +20,4 @@ NO_AS_NEEDED = 'Upstream asneeded linking bug (no-as-needed on line: %d)'
 PRESERVE_OLD_LIB = 'Upstream ABI change workaround on line: %d'
 BUILT_WITH_USE = 'built_with_use on line: %d'
 EPREFIXIFY_MISSING_INHERIT = "prefix.eclass is not inherited, but eprefixify is used on line: %d"
+SANDBOX_ADDPREDICT = 'Ebuild calls addpredict on line: %d'