Re: [Patch v2 0/4] Control selection of From: header when replying

diff --git a/15/9bb97495f9f83ab2f99f0b2e587cbc07ace9dd b/15/9bb97495f9f83ab2f99f0b2e587cbc07ace9dd
new file mode 100644 (file)
index 0000000..fb3e5ef
--- /dev/null
+++ b/15/9bb97495f9f83ab2f99f0b2e587cbc07ace9dd
@@ -0,0 +1,122 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id F307A431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Feb 2012 05:12:22 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id O4JxxKDqPkrK for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Feb 2012 05:12:22 -0800 (PST)\r
+Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0323E431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Feb 2012 05:12:21 -0800 (PST)\r
+Received: by lahd3 with SMTP id d3so2875264lah.26\r
+       for <notmuch@notmuchmail.org>; Sun, 05 Feb 2012 05:12:20 -0800 (PST)\r
+Received: by 10.152.123.68 with SMTP id ly4mr1987063lab.13.1328447538847;\r
+       Sun, 05 Feb 2012 05:12:18 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw4-fe50f800-253.dhcp.inet.fi.\r
+       [84.248.80.253])\r
+       by mx.google.com with ESMTPS id z2sm10271622lbk.7.2012.02.05.05.12.15\r
+       (version=SSLv3 cipher=OTHER); Sun, 05 Feb 2012 05:12:17 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,\r
+       Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 0/4] Control selection of From: header when replying\r
+In-Reply-To: <87ipjlix6r.fsf@gmail.com>\r
+References: <1328388317-20161-1-git-send-email-markwalters1009@gmail.com>\r
+       <87ipjlix6r.fsf@gmail.com>\r
+User-Agent: Notmuch/0.11+139~g4340989 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+Date: Sun, 05 Feb 2012 15:12:14 +0200\r
+Message-ID: <877h01a0gh.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 Feb 2012 13:12:23 -0000\r
+\r
+On Sun, 05 Feb 2012 10:58:04 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> Hi Mark.\r
+> \r
+> I am not sure I like this solution.  My concerns are:\r
+> \r
+> * New option looks too complex, too specific.\r
+\r
+*shrug* The --from parameter is simple to implement, simple to test, and\r
+simple to use.\r
+\r
+> * There are more aspects of notmuch reply behavior which users would\r
+>   like to change (e.g. which part to quote).  If we add an option for\r
+>   each, we complicate both nomtuch show UI and code.\r
+\r
+This I agree is more of an issue.\r
+\r
+> The problem is that notmuch show output format is too limiting.  Instead\r
+> of providing myriad of options for tweaking notmuch show text format\r
+> behavior, we should add JSON format for notmuch reply similar to nomtuch\r
+> show.  That would allow notmuch reply to produce structured output with\r
+> required additional information, which should be enough for users to\r
+> construct whatever reply they want.\r
+\r
+Heh, when I told Mark on IRC to just send the patches and not discuss\r
+and worry about it too much, I added "...and then someone will come up\r
+with an approach we failed to think of, and scrap the whole\r
+thing". Thanks Dmitry! ;)\r
+\r
+> In this particular case, notmuch reply JSON format could have\r
+> "from-source" attribute that would indicate how it was guessed.\r
+\r
+My first thought is that it's offloading things that are trivial in the\r
+cli to the users of the cli where it might be slightly more complicated,\r
+but...\r
+\r
+> Now the best part.  Not so long ago, Adam (in Cc) provided a patch for\r
+> improving nomtuch reply for HTML-only emails.  At first he added an\r
+> option for notmuch reply, like you did for from-guessing.  I suggested\r
+> him to implement it based on the JSON format instead and he did.  AFAIK\r
+> the latest version of his patches is [1].  I did not look at the code\r
+> though.  It seems that it is waiting for more review.\r
+> \r
+> So, instead of adding more nomtuch show options, I think a better\r
+> solution is to work with Adam to get the notmuch reply JSON format to\r
+> master and then fix the from-guessing issue by adding an attribute to\r
+> notmuch reply JSON format.\r
+\r
+...no matter what the solution will be in the end, I agree it's best to\r
+get Adam's work merged first, and see how easily this can be handled\r
+using JSON vs. the parameter.\r
+\r
+Thanks for your insights.\r
+\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+> Regards,\r
+>   Dmitry\r
+> \r
+> [1] id:"1326995217-27423-1-git-send-email-awg+notmuch@xvx.ca"\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r