Re: [PATCH] emacs: Make moving to the previous message move to the previous boundary

diff --git a/b1/2662367210b2cbe47aa35a45558f59eadb6c55 b/b1/2662367210b2cbe47aa35a45558f59eadb6c55
new file mode 100644 (file)
index 0000000..e998838
--- /dev/null
+++ b/b1/2662367210b2cbe47aa35a45558f59eadb6c55
@@ -0,0 +1,113 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CCC45431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  6 Aug 2012 07:29:01 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 4wl+LICsmT0I for <notmuch@notmuchmail.org>;\r
+       Mon,  6 Aug 2012 07:29:01 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id DA0D5431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  6 Aug 2012 07:29:00 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id CE58B1002A4; Mon,  6 Aug 2012 17:29:10 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Make moving to the previous message move to the\r
+       previous boundary\r
+In-Reply-To: <1342237668-2489-1-git-send-email-amdragon@mit.edu>\r
+References: <1342237668-2489-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13.2+128~g07453d8 (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 06 Aug 2012 17:29:10 +0300\r
+Message-ID: <m2d334ksax.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Aug 2012 14:29:01 -0000\r
+\r
+On Sat, Jul 14 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Previously, notmuch-show-previous-message would move to the beginning\r
+> of the message before the message containing point.  This patch makes\r
+> it instead move to the previous message *boundary*.  That is, if point\r
+> isn't already at the beginning of the message, it moves to the\r
+> beginning of the current message.  This is consistent with\r
+> notmuch-show-next-message, which can be thought of as moving to the\r
+> next message boundary.  Several people have expressed a preference for\r
+> this.\r
+> ---\r
+\r
+LGTM. Contrary to what I wrote in id:"m2pq746tlq.fsf@guru.guru-group.fi"\r
+I think this could be pushed...\r
+\r
+Tomi\r
+\r
+> This patch accompanies the series in [0] (though they're independent\r
+> and can be applied in either order).  This makes the behavior of 'p'\r
+> and 'P' in show-mode conceptually similar to the new behavior of 'p'\r
+> in search-mode.\r
+>\r
+> [0] 1342140319-19859-1-git-send-email-amdragon@mit.edu\r
+>\r
+>  emacs/notmuch-show.el |   10 +++++++---\r
+>  1 file changed, 7 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 6335d45..02e319f 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1525,9 +1525,11 @@ thread, navigate to the next thread in the parent search buffer."\r
+>        (goto-char (point-max)))))\r
+>  \r
+>  (defun notmuch-show-previous-message ()\r
+> -  "Show the previous message."\r
+> +  "Show the previous message or the start of the current message."\r
+>    (interactive)\r
+> -  (notmuch-show-goto-message-previous)\r
+> +  (if (= (point) (notmuch-show-message-top))\r
+> +      (notmuch-show-goto-message-previous)\r
+> +    (notmuch-show-move-to-message-top))\r
+>    (notmuch-show-mark-read)\r
+>    (notmuch-show-message-adjust))\r
+>  \r
+> @@ -1587,7 +1589,9 @@ to show, nil otherwise."\r
+>  (defun notmuch-show-previous-open-message ()\r
+>    "Show the previous open message."\r
+>    (interactive)\r
+> -  (while (and (notmuch-show-goto-message-previous)\r
+> +  (while (and (if (= (point) (notmuch-show-message-top))\r
+> +              (notmuch-show-goto-message-previous)\r
+> +            (notmuch-show-move-to-message-top))\r
+>            (not (notmuch-show-message-visible-p))))\r
+>    (notmuch-show-mark-read)\r
+>    (notmuch-show-message-adjust))\r
+> -- \r
+> 1.7.10\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r