Re: Improving spam-tagging keybinding function to act on region in emacs

diff --git a/21/15b354e81d93d5221fd3faf001f6baa2e0710d b/21/15b354e81d93d5221fd3faf001f6baa2e0710d
new file mode 100644 (file)
index 0000000..d6417cc
--- /dev/null
+++ b/21/15b354e81d93d5221fd3faf001f6baa2e0710d
@@ -0,0 +1,98 @@
+Return-Path: <olivier.berger@telecom-sudparis.eu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 122C3431FBC\r
+       for <notmuch@notmuchmail.org>; Thu, 22 May 2014 01:59:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id sKd-mh42etNI for <notmuch@notmuchmail.org>;\r
+       Thu, 22 May 2014 01:59:17 -0700 (PDT)\r
+Received: from zproxy120.enst.fr (zproxy120.enst.fr [137.194.52.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 74A3C431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 22 May 2014 01:59:17 -0700 (PDT)\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by zproxy120.enst.fr (Postfix) with ESMTP id 7FE5610055A;\r
+       Thu, 22 May 2014 10:59:13 +0200 (CEST)\r
+Received: from zproxy120.enst.fr ([127.0.0.1])\r
+       by localhost (zproxy120.enst.fr [127.0.0.1]) (amavisd-new, port 10032)\r
+       with ESMTP id 1VN9HJkofbls; Thu, 22 May 2014 10:59:09 +0200 (CEST)\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by zproxy120.enst.fr (Postfix) with ESMTP id 5324D100544;\r
+       Thu, 22 May 2014 10:59:09 +0200 (CEST)\r
+X-Virus-Scanned: amavisd-new at zproxy120.enst.fr\r
+Received: from zproxy120.enst.fr ([127.0.0.1])\r
+       by localhost (zproxy120.enst.fr [127.0.0.1]) (amavisd-new, port 10026)\r
+       with ESMTP id IMcP7Vl-UEVM; Thu, 22 May 2014 10:59:09 +0200 (CEST)\r
+Received: from localhost (bauxite.int-evry.fr [157.159.110.64])\r
+       by zproxy120.enst.fr (Postfix) with ESMTPSA id 2B2E2100541;\r
+       Thu, 22 May 2014 10:59:09 +0200 (CEST)\r
+From: Olivier Berger <olivier.berger@telecom-sudparis.eu>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: Improving spam-tagging keybinding function to act on region in\r
+       emacs\r
+In-Reply-To: <87wqde6xup.fsf@qmul.ac.uk>\r
+References: <87oazb9k5f.fsf@inf-8660.int-evry.fr> <87mweuzy87.fsf@qmul.ac.uk>\r
+       <87bnv92521.fsf@inf-8660.int-evry.fr> <87wqde6xup.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 22 May 2014 10:59:07 +0200\r
+Message-ID: <87wqdechpg.fsf@inf-8660.int-evry.fr>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 22 May 2014 08:59:23 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> On Wed, 07 May 2014, Olivier Berger <olivier.berger@telecom-sudparis.eu> wrote:\r
+>>>\r
+>>\r
+>> Note that I'm now using the following :\r
+>>   (define-key notmuch-search-mode-map "S"\r
+>>         (lambda (&optional beg end)\r
+>>           "mark messages in thread as spam"\r
+>>           (interactive (notmuch-search-interactive-region))\r
+>>           (notmuch-search-tag '("+spam" "-inbox") beg end)\r
+>>           (if (eq beg end) (notmuch-search-next-thread))))\r
+>>\r
+>> This offers the possibility to jump to the next line when tagging\r
+>> individual lines, and not do so when acting on a region.\r
+>>\r
+>> Btw, such a difference in behaviour may be a tiny, but still nice\r
+>> improvement on the code of notmuch-search-archive-thread too.\r
+>\r
+> I think this is worth doing: do you want to send a patch? The above lisp\r
+> is fine but I would replace the "if" by "when". (The main difference is\r
+> that "when" cannot take an else clause so using when flags up that there\r
+> is not an else clause.)\r
+>\r
+> If the above is inconvenient then I am happy to post such a patch.\r
+>\r
+\r
+AFAI'm concerned, feel free to do so ;)\r
+\r
+Best regards,\r
+-- \r
+Olivier BERGER \r
+http://www-public.telecom-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8\r
+Ingenieur Recherche - Dept INF\r
+Institut Mines-Telecom, Telecom SudParis, Evry (France)\r