Re: [PATCH 1/2] test: check for debug symbols in notmuch
authorTomi Ollila <tomi.ollila@iki.fi>
Fri, 3 Oct 2014 20:49:31 +0000 (23:49 +0300)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:04:57 +0000 (10:04 -0800)
b4/14c6eed244c80cd0b80f52e70ac573dc70c04d [new file with mode: 0644]

diff --git a/b4/14c6eed244c80cd0b80f52e70ac573dc70c04d b/b4/14c6eed244c80cd0b80f52e70ac573dc70c04d
new file mode 100644 (file)
index 0000000..9015b38
--- /dev/null
@@ -0,0 +1,86 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 21EE4431FBC\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 13:49:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Mz0DUoEg7la7 for <notmuch@notmuchmail.org>;\r
+       Fri,  3 Oct 2014 13:49:43 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id D4834431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 13:49:42 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id AD54A10008D;\r
+       Fri,  3 Oct 2014 23:49:31 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] test: check for debug symbols in notmuch\r
+In-Reply-To: <1412367730-25890-1-git-send-email-david@tethera.net>\r
+References: <1412367730-25890-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.18.1+119~g5d90feb (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 03 Oct 2014 23:49:31 +0300\r
+Message-ID: <m21tqoho9w.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 03 Oct 2014 20:49:47 -0000\r
+\r
+On Fri, Oct 03 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> In the future, tests may rely on debug symbols being present in\r
+> notmuch, so we plan to switch the default flags.\r
+>\r
+> The main purpose of this test is to help explain the perhaps\r
+> mysterious failures of other tests which rely on symbols being\r
+> present.\r
+> ---\r
+\r
+series LGTM.\r
+\r
+>  test/T000-basic.sh | 5 +++++\r
+>  1 file changed, 5 insertions(+)\r
+>\r
+> diff --git a/test/T000-basic.sh b/test/T000-basic.sh\r
+> index ebbb6d2..bf08f3e 100755\r
+> --- a/test/T000-basic.sh\r
+> +++ b/test/T000-basic.sh\r
+> @@ -91,4 +91,9 @@ test_expect_equal \\r
+>      "$(dirname ${TEST_DIRECTORY})" \\r
+>      "$(echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,')"\r
+>  \r
+> +test_begin_subtest 'notmuch is compiled with debugging symbols'\r
+> +test_subtest_known_broken\r
+> +readelf --sections $(which notmuch) | grep \.debug\r
+> +test_expect_equal 0 $?\r
+> +\r
+>  test_done\r
+> -- \r
+> 2.1.0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r