Re: [PATCH] debian: package ruby bindings

diff --git a/f5/0a1512cc8fa055777c349025b1ff6d6ffcc6f3 b/f5/0a1512cc8fa055777c349025b1ff6d6ffcc6f3
new file mode 100644 (file)
index 0000000..bd5f055
--- /dev/null
+++ b/f5/0a1512cc8fa055777c349025b1ff6d6ffcc6f3
@@ -0,0 +1,133 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 338D9431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 14 Apr 2013 06:53:21 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id HTNm4+xScrY9 for <notmuch@notmuchmail.org>;\r
+       Sun, 14 Apr 2013 06:53:20 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id EEAF8431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 14 Apr 2013 06:53:19 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1URNMq-0005hn-D1; Sun, 14 Apr 2013 10:53:16 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1URNMG-0005Ze-Md; Sun, 14 Apr 2013 10:52:40 -0300\r
+From: David Bremner <bremner@debian.org>\r
+To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] debian: package ruby bindings\r
+In-Reply-To: <1365031678-25188-1-git-send-email-felipe.contreras@gmail.com>\r
+References: <1365031678-25188-1-git-send-email-felipe.contreras@gmail.com>\r
+User-Agent: Notmuch/0.15.2+73~g1c450ec (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 14 Apr 2013 10:52:40 -0300\r
+Message-ID: <87y5clte1j.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 14 Apr 2013 13:53:21 -0000\r
+\r
+Felipe Contreras <felipe.contreras@gmail.com> writes:\r
+\r
+>\r
+> diff --git a/debian/control b/debian/control\r
+> index 854a32a..620c5ce 100644\r
+> --- a/debian/control\r
+> +++ b/debian/control\r
+> @@ -15,6 +15,7 @@ Build-Depends:\r
+>   libz-dev,\r
+>   python-all (>= 2.6.6-3~),\r
+>   python3-all (>= 3.1.2-7~),\r
+> + ruby-dev,\r
+>   emacs23-nox | emacs23 (>=23~) | emacs23-lucid (>=23~) |\r
+>   emacs24-nox | emacs24 (>=24~) | emacs24-lucid (>=24~),\r
+>   gdb,\r
+\r
+This doesn't build in a clean sid chroot, because ruby-dev does not\r
+depend on ruby, so you need to explicitly add it.\r
+\r
+>  Package: notmuch-emacs\r
+>  Architecture: all\r
+>  Section: mail\r
+> diff --git a/debian/notmuch-ruby.install b/debian/notmuch-ruby.install\r
+> new file mode 100644\r
+> index 0000000..f92f09c\r
+> --- /dev/null\r
+> +++ b/debian/notmuch-ruby.install\r
+> @@ -0,0 +1 @@\r
+> +usr/local/lib/site_ruby/*/*/notmuch.so\r
+> diff --git a/debian/rules b/debian/rules\r
+> index c4e3930..7c7247a 100755\r
+> --- a/debian/rules\r
+> +++ b/debian/rules\r
+> @@ -12,15 +12,24 @@ override_dh_auto_build:\r
+>      dh_auto_build\r
+>      dh_auto_build --sourcedirectory bindings/python\r
+>      cd bindings/python && $(python3_all) setup.py build\r
+> +    dh_auto_build --sourcedirectory bindings/ruby\r
+> +    cd bindings/ruby && ruby extconf.rb && make\r
+\r
+Why are both these lines needed? On a related note, is the ruby build\r
+procedure documented somewhere?\r
+\r
+>  override_dh_auto_clean:\r
+>      dh_auto_clean\r
+>      dh_auto_clean --sourcedirectory bindings/python\r
+>      cd bindings/python && $(python3_all) setup.py clean -a\r
+> +    dh_auto_build --sourcedirectory bindings/ruby\r
+> +    cd bindings/ruby && test -f Makefile && make clean || true\r
+>      $(MAKE) -C contrib/notmuch-mutt clean\r
+\r
+This looks suspect, calling dh_auto_build from the clean target. The\r
+clean target cannot assume that e.g. notmuch is already built.\r
+\r
+>  override_dh_auto_install:\r
+>      dh_auto_install\r
+>      dh_auto_install --sourcedirectory bindings/python\r
+>      cd bindings/python && $(python3_all) setup.py install --install-layout=deb --root=$(CURDIR)/debian/tmp\r
+> +    dh_auto_build --sourcedirectory bindings/ruby\r
+> +    cd bindings/ruby && make install DESTDIR=$(CURDIR)/debian/tmp\r
+\r
+This call to dh_auto_build also confuses me. The top level sequencer\r
+will ensure that the override_dh_auto_build is called before this one.\r
+\r
+> +\r
+> +# ruby's site is configured in /usr/local\r
+> +override_dh_usrlocal:\r
+\r
+The package is still installing files into /usr/local, which is a\r
+violation of debian policy 9.1.2\r
+\r
+It's a good idea to run "lintian" on the resulting debian packages;\r
+that's how I caught the problem with /usr/local.\r
+\r
+d\r
+\r
+\r