Re: [PATCH] emacs: hello: make --batch error gracefully

diff --git a/11/779c142c4f994e45ae43b341fe06e25e5b432b b/11/779c142c4f994e45ae43b341fe06e25e5b432b
new file mode 100644 (file)
index 0000000..fd263b6
--- /dev/null
+++ b/11/779c142c4f994e45ae43b341fe06e25e5b432b
@@ -0,0 +1,77 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 443A2431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 23 Jul 2013 19:28:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8RtezQZbH6Ir for <notmuch@notmuchmail.org>;\r
+       Tue, 23 Jul 2013 19:28:19 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8B88E431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 23 Jul 2013 19:28:19 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1V1ooI-000278-Rt; Tue, 23 Jul 2013 23:28:14 -0300\r
+Received: (nullmailer pid 23197 invoked by uid 1000); Wed, 24 Jul 2013\r
+       02:28:11 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH] emacs: hello: make --batch error gracefully\r
+In-Reply-To: <1372976299-30389-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1372976299-30389-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 23 Jul 2013 23:28:11 -0300\r
+Message-ID: <87ob9svghw.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch mailing list <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 24 Jul 2013 02:28:24 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+> -    (call-process-region (point-min) (point-max) notmuch-command\r
+> -                     t t nil "count" "--batch")\r
+> +    (unless (= (call-process-region (point-min) (point-max) notmuch-command\r
+> +                                t t nil "count" "--batch") 0)\r
+> +      (notmuch-logged-error "notmuch CLI version mismatch error (count --batch)\r
+> +The most likely cause of this error is that the CLI is too old\r
+> +to support count --batch and needs to be upgraded to the same\r
+> +version as notmuch-emacs"))\r
+> +\r
+\r
+I had a look at this, and I agree the current failure mode is not nice\r
+(it just says something mysterious about nil not being a string). On the\r
+other hand, I think we should use the two argument form of\r
+notmuch-logged-error, and the the first argument should say only what we\r
+know. Something like\r
+\r
+(notmuch-logged-error "notmuch count --batch failed"\r
+"notmuch count --batch failed\r
+Please check that the notmuch CLI is new enough to  support `count\r
+--batch'. In general we recommend running matching versions of the CLI\r
+and emacs interface.")\r
+\r
+d\r
+\r