Re: [PATCH] use notmuch_database_open_verbose

diff --git a/1e/4e9bd785a212c86105360bbee8734d0d443afe b/1e/4e9bd785a212c86105360bbee8734d0d443afe
new file mode 100644 (file)
index 0000000..a20ef0e
--- /dev/null
+++ b/1e/4e9bd785a212c86105360bbee8734d0d443afe
@@ -0,0 +1,70 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id CD2826DE1868\r
+ for <notmuch@notmuchmail.org>; Sat, 12 Mar 2016 08:33:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.031\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.031 tagged_above=-999 required=5\r
+ tests=[AWL=-0.020, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id GKsqVBwQ8VhZ for <notmuch@notmuchmail.org>;\r
+ Sat, 12 Mar 2016 08:33:53 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id D664E6DE1867\r
+ for <notmuch@notmuchmail.org>; Sat, 12 Mar 2016 08:33:52 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1aemUn-0007wX-AX; Sat, 12 Mar 2016 11:34:29 -0500\r
+Received: (nullmailer pid 32316 invoked by uid 1000);\r
+ Sat, 12 Mar 2016 16:33:50 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Patrick Totzke <patricktotzke@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] use notmuch_database_open_verbose\r
+In-Reply-To: <87r3ff64sa.fsf@zancas.localnet>\r
+References: <1457795857-12410-1-git-send-email-patricktotzke@gmail.com>\r
+ <87r3ff64sa.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 12 Mar 2016 12:33:50 -0400\r
+Message-ID: <87oaaj64gh.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 12 Mar 2016 16:33:55 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+>> -    """notmuch_database_open"""\r
+>> -    _open = nmlib.notmuch_database_open\r
+>> +    """notmuch_database_open_verbose"""\r
+>> +    _open = nmlib.notmuch_database_open_verbose\r
+>>      _open.argtypes = [c_char_p, c_uint, POINTER(NotmuchDatabaseP)]\r
+>>      _open.restype = c_uint\r
+>\r
+> I expect you probably want to add the new binding, rather than replacing\r
+> the old one. Otherwise updating the bindings will break all bindings\r
+> using scripts.\r
+\r
+Oh silly me. That's not actually exposed to the python API, so that's\r
+fine. On the other hand, don't you want to update the argument types and\r
+do something useful (throw an exception?) with the returned message?  As\r
+it stands you lose information.\r
+\r
+d\r