format-patch: use clear_commit_marks() instead of some ad-hockery
authorJohannes Schindelin <Johannes.Schindelin@gmx.de>
Tue, 27 Jun 2006 20:38:04 +0000 (22:38 +0200)
committerJunio C Hamano <junkio@cox.net>
Tue, 27 Jun 2006 23:03:59 +0000 (16:03 -0700)
It is cleaner, and it describes better what the idea behind the code is.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
builtin-log.c

index 4ee5891dfd63e24db811bbc5f32f87f0f6b233ad..f9515a8a4ac8a53e87b6fb9f73e1964350481bfb 100644 (file)
@@ -160,15 +160,6 @@ static void reopen_stdout(struct commit *commit, int nr, int keep_subject)
        freopen(filename, "w", stdout);
 }
 
-static void reset_all_objects_flags()
-{
-       int i;
-
-       for (i = 0; i < obj_allocs; i++)
-               if (objs[i])
-                       objs[i]->flags = 0;
-}
-
 static int get_patch_id(struct commit *commit, struct diff_options *options,
                unsigned char *sha1)
 {
@@ -220,7 +211,10 @@ static void get_patch_ids(struct rev_info *rev, struct diff_options *options)
        }
 
        /* reset for next revision walk */
-       reset_all_objects_flags();
+       clear_commit_marks((struct commit *)o1,
+                       SEEN | UNINTERESTING | SHOWN | ADDED);
+       clear_commit_marks((struct commit *)o2,
+                       SEEN | UNINTERESTING | SHOWN | ADDED);
        o1->flags = flags1;
        o2->flags = flags2;
 }