Re: [PATCH] test/README: have matching test script file names
authorW. Trevor King <wking@tremily.us>
Fri, 12 Feb 2016 19:38:40 +0000 (11:38 +1600)
committerW. Trevor King <wking@tremily.us>
Sat, 20 Aug 2016 23:21:06 +0000 (16:21 -0700)
ba/84715cbac1b5779c88ba18f30906cc04f0f0f6 [new file with mode: 0644]

diff --git a/ba/84715cbac1b5779c88ba18f30906cc04f0f0f6 b/ba/84715cbac1b5779c88ba18f30906cc04f0f0f6
new file mode 100644 (file)
index 0000000..fbca372
--- /dev/null
@@ -0,0 +1,140 @@
+Return-Path: <wking@tremily.us>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id D0A4E6DE17DB\r
+ for <notmuch@notmuchmail.org>; Fri, 12 Feb 2016 11:38:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.008\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.008 tagged_above=-999 required=5 tests=[AWL=0.109, \r
+ DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id fTC-eeCWonDz for <notmuch@notmuchmail.org>;\r
+ Fri, 12 Feb 2016 11:38:44 -0800 (PST)\r
+Received: from resqmta-po-04v.sys.comcast.net (resqmta-po-04v.sys.comcast.net\r
+ [96.114.154.163])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 48CD06DE1638\r
+ for <notmuch@notmuchmail.org>; Fri, 12 Feb 2016 11:38:44 -0800 (PST)\r
+Received: from resomta-po-05v.sys.comcast.net ([96.114.154.229])\r
+ by resqmta-po-04v.sys.comcast.net with comcast\r
+ id HXcu1s0094xDoy801XejfR; Fri, 12 Feb 2016 19:38:43 +0000\r
+Received: from mail.tremily.us ([73.221.72.168])\r
+ by resomta-po-05v.sys.comcast.net with comcast\r
+ id HXeh1s0093dr3C901XehcP; Fri, 12 Feb 2016 19:38:42 +0000\r
+Received: by mail.tremily.us (Postfix, from userid 1000)\r
+ id DC40C1BAF067; Fri, 12 Feb 2016 11:38:40 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin;\r
+ t=1455305920; bh=wLY4uRTVuFPUuZBIoedhVKtrnAcUQK1RALfQG4itJKU=;\r
+ h=Date:From:To:Cc:Subject:References:In-Reply-To;\r
+ b=jw5hGc8fL5DnGAew4wBaAqRFf5G9y48VS2wy6U1HOhhbj3aIxdYJTRFeR5mt6zdoO\r
+ c7leGc+LkYZynmbJqvf+Qqr0cTku5/l4sIZTOtZmUlDTvak4lsaJmksW3eS20mFOm4\r
+ XzUQYVuexyY3bk6VdhzuUvI9kwwMdF/rlmdlzpOM=\r
+Date: Fri, 12 Feb 2016 11:38:40 -0800\r
+From: "W. Trevor King" <wking@tremily.us>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Cc: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test/README: have matching test script file names\r
+Message-ID: <20160212193840.GV4265@odin.tremily.us>\r
+References: <1455304620-14588-1-git-send-email-tomi.ollila@iki.fi>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; micalg=pgp-sha1;\r
+ protocol="application/pgp-signature"; boundary="gkEBo/XPSfx+3zOU"\r
+Content-Disposition: inline\r
+In-Reply-To: <1455304620-14588-1-git-send-email-tomi.ollila@iki.fi>\r
+OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;\r
+ url=http://tremily.us/pubkey.txt\r
+User-Agent: Mutt/1.5.23 (2014-03-12)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
+ s=q20140121; t=1455305923;\r
+ bh=WbgPflleR0zhKCZklb83VO2o9WGiD6K+Aac0hga8sI4=;\r
+ h=Received:Received:Received:Date:From:To:Subject:Message-ID:\r
+ MIME-Version:Content-Type;\r
+ b=W9+p7EoJ3n0U7Z+yE4gPhMGOBVjT9UmeShgVE542MCdu0HdO4i+ZuZ91z4hXVOfpr\r
+ ny1HHk9B/wDek7BPS40WQN+JmO9faBO5pRnTH8kjy+2iD76t1l+9Iu/nDR26qzF7+9\r
+ 01HRLK0dzllKd6a6JQdtIT8GCHfSCEBiJWla5e/K6T4F82v+MkZN4EDSqslRRxBNT7\r
+ 1viAIefWD0ai8ftkSCdidKDK2YnEgDqwTv5rMnb2fwypPYY+4crxQZJoFxyVG21eUc\r
+ UH66s7DInuZTj9F8vtch14t1FtUXNsmZQglgQiXZinh+zcKoJyr8GKcOJe0pu1s/cv\r
+ UEuk0aEjDWylw==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 12 Feb 2016 19:38:48 -0000\r
+\r
+\r
+--gkEBo/XPSfx+3zOU\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Fri, Feb 12, 2016 at 09:17:00PM +0200, Tomi Ollila wrote:\r
+> +The test system itself requires:\r
+> +\r
+> +  - bash(1) version 4.0 or newer\r
+> +\r
+> +Without bash 4.0+ the tests just refuse to run.\r
+\r
+This was surprising to me (obviously I haven't looked at the test\r
+library closely ;), because Git tries to maintain compatiblity with\r
+POSIX [1] and Git is the source of notmuch's test framework [2].  But\r
+it looks like notmuch's fork of the test framework was Bash-specific\r
+=66rom 0d67c52f (notmuch-test: Use named-parameters for generate_message\r
+function, 2010-02-03).  That commit happened before the Git framework,\r
+but we still have the code it added:\r
+\r
+    # This is our (bash-specific) magic for doing named parameters         =\r
+                                                                           =\r
+                       =20\r
+    local -A template=3D"($@)"\r
+\r
+Carl explicitly motivated the change in his commit message.  +1 to\r
+documenting the requirement explicitly in the README, although users\r
+should have been getting nice error messages since 20018a0c (test:\r
+Emit a friendly error message if run with bash < 4.0, 2010-10-28).\r
+\r
+Cheers,\r
+Trevor\r
+\r
+[1]: https://git.kernel.org/cgit/git/git.git/tree/Documentation/CodingGuide=\r
+lines?h=3Dv2.7.1\r
+[2]: 0083854 (Copy test framework from Git, 2010-06-10)\r
+\r
+--=20\r
+This email may be signed or encrypted with GnuPG (http://www.gnupg.org).\r
+For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\r
+\r
+--gkEBo/XPSfx+3zOU\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+Content-Description: OpenPGP digital signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v2\r
+\r
+iQIcBAEBAgAGBQJWvjS+AAoJEAPqygegUbGsBsAQAIcqG/DhfnqMIXtZRzbyAfw8\r
+XswP2r2p3DWB7r9UMiBV2PNbY6epeLl0fMX/1baRdrb5QZlfLrews4A0ctOvGMle\r
+WOcxL2GFx37b2yzJ3iQcEbZ49E7Ns/0hmKPS6eD6NXVksMr0ujGNPowbUBC8qJ0c\r
+lCPmwcQIDCCZxAB9smhszTYuTjgi84cwS3VfxbrOD0WBbiKD+tCZ/2ghIf2rYpSQ\r
+Ziwm6JLPwalifO3uisjT01YtkbPHd9YMdSIrPH5giMcEUuXA2Mk2D0BYpPmiiX+g\r
+VZjUEcYES4ko1IyhMlzQcxFoEqIkl6SvZYm2Tn/apHmaCzEZyB9qNTH/+HbhkQwI\r
+XnHqcW4SqmsZN+4meB19FdNdNY/Qe/pLyZLKxpz6enXLt+paahc/Lxv86E86MPCO\r
+Q2OFw6IaobYUCGjPyy1g4OfBj/PCSS0fRc+4fyTGlMip449uIRDGLB4z/0sjYGDn\r
+XIlBUlW6HFpyS5hMjSX3OP0IelEl7hBJUYLJE2AbdpLp1Rfb52e8VJioMPpWFykZ\r
+0Yp1DTb0WiVwwX17mjrUixYKFLBXuQiNejd4j+e39/lFEhQgt/Qc+/Wc45KV348y\r
+m+6IJqc5c45zpdlxWRWQg+Ilplu6fTGjwmPrP/Orahl3adunxsHCL9nxhOwbsOfK\r
+6szdocDPbHY9wZ5HHIct\r
+=ZPVl\r
+-----END PGP SIGNATURE-----\r
+\r
+--gkEBo/XPSfx+3zOU--\r