Re: [PATCH 06/11] emacs: Remove broken `notmuch-get-bodypart-content' API

diff --git a/eb/7278c2bdd5fe26aaf78c765f1074b4f4aaa982 b/eb/7278c2bdd5fe26aaf78c765f1074b4f4aaa982
new file mode 100644 (file)
index 0000000..c98303f
--- /dev/null
+++ b/eb/7278c2bdd5fe26aaf78c765f1074b4f4aaa982
@@ -0,0 +1,82 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B0D4E431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 11 Jul 2014 04:49:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ujqRBAecQr4Z for <notmuch@notmuchmail.org>;\r
+       Fri, 11 Jul 2014 04:49:02 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E6946431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 11 Jul 2014 04:49:02 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1X5ZJw-0004Ry-HP; Fri, 11 Jul 2014 08:48:56 -0300\r
+Received: (nullmailer pid 7290 invoked by uid 1000); Fri, 11 Jul 2014\r
+       11:48:52 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 06/11] emacs: Remove broken\r
+       `notmuch-get-bodypart-content' API\r
+In-Reply-To: <1398105468-14317-7-git-send-email-amdragon@mit.edu>\r
+References: <1398105468-14317-1-git-send-email-amdragon@mit.edu>\r
+       <1398105468-14317-7-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 11 Jul 2014 08:48:52 -0300\r
+Message-ID: <8738e8p13v.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 11 Jul 2014 11:49:07 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> +This returns the content of the given part as a multibyte Lisp\r
+\r
+What does "multibyte" mean here? utf8? current encoding?\r
+\r
+> +string after performing content transfer decoding and any\r
+> +necessary charset decoding.  It is an error to use this for\r
+> +non-text/* parts."\r
+> +  (let ((content (plist-get part :content)))\r
+> +    (when (not content)\r
+> +      ;; Use show --format=sexp to fetch decoded content\r
+> +      (let* ((args `("show" "--format=sexp" "--include-html"\r
+> +                 ,(format "--part=%s" (plist-get part :id))\r
+> +                 ,@(when process-crypto '("--decrypt"))\r
+> +                 ,(notmuch-id-to-query (plist-get msg :id))))\r
+> +         (npart (apply #'notmuch-call-notmuch-sexp args)))\r
+> +    (setq content (plist-get npart :content))\r
+> +    (when (not content)\r
+> +      (error "Internal error: No :content from %S" args))))\r
+> +    content))\r
+\r
+I'm a bit curious at the lack of setting "coding-system-for-read" here.\r
+Are we assuming the user has their environment set up correctly? Not so\r
+much a criticism as being nervous about everything coding-system\r
+related.\r
+\r
+I didn't see anything else to object to in this patch or the previous\r
+one.\r