projects
/
git.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
07873dc
)
transport-helper.c: fix check for (size_t < 0)
author
Nicolas Kaiser
<nikai@nikai.net>
Fri, 4 Mar 2011 23:16:26 +0000
(
00:16
+0100)
committer
Junio C Hamano
<gitster@pobox.com>
Wed, 9 Mar 2011 05:36:12 +0000
(21:36 -0800)
'bytes' is of type size_t which is unsigned thus can't be negative. But
the assigned write() returns ssize_t, and -1 on error.
For testing < 0, 'bytes' needs to be of a signed type.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
transport-helper.c
patch
|
blob
|
history
diff --git
a/transport-helper.c
b/transport-helper.c
index 4e4754c32bd53f28f9335c2a4529f5804f3086f2..ba06b70cce6ecc5822fd86d2e3579be76dbeaa33 100644
(file)
--- a/
transport-helper.c
+++ b/
transport-helper.c
@@
-973,7
+973,7
@@
static int udt_do_read(struct unidirectional_transfer *t)
*/
static int udt_do_write(struct unidirectional_transfer *t)
{
- size_t bytes;
+ s
s
ize_t bytes;
if (t->bufuse == 0)
return 0; /* Nothing to write. */