Re: [PATCH 1/1] emacs: Makefile.local: HAVE_EMACS usage fixes

diff --git a/a8/18631c06218cc02f5a57ff5735a54b0b06b19b b/a8/18631c06218cc02f5a57ff5735a54b0b06b19b
new file mode 100644 (file)
index 0000000..ace4121
--- /dev/null
+++ b/a8/18631c06218cc02f5a57ff5735a54b0b06b19b
@@ -0,0 +1,93 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D03D8431FD7\r
+       for <notmuch@notmuchmail.org>; Wed,  4 Dec 2013 11:27:45 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id rYKgK2s4g5Oy for <notmuch@notmuchmail.org>;\r
+       Wed,  4 Dec 2013 11:27:36 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9099D431FD0\r
+       for <notmuch@notmuchmail.org>; Wed,  4 Dec 2013 11:27:36 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 406E3100086;\r
+       Wed,  4 Dec 2013 21:27:30 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/1] emacs: Makefile.local: HAVE_EMACS usage fixes\r
+In-Reply-To: <87ob523snl.fsf@zancas.localnet>\r
+References: <1377630047-27756-1-git-send-email-tomi.ollila@iki.fi>\r
+       <87ob523snl.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.17~rc1+17~ga2e1a2f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 04 Dec 2013 21:27:29 +0200\r
+Message-ID: <m2mwkgmn6m.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 04 Dec 2013 19:27:46 -0000\r
+\r
+On Sat, Nov 30 2013, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>>  \r
+>>  ifeq ($(WITH_EMACS),1)\r
+>>  ifeq ($(HAVE_EMACS),1)\r
+>>  all: $(emacs_bytecode)\r
+>> +install-emacs: $(emacs_bytecode)\r
+>>  endif\r
+>>  \r
+>\r
+> It's a bit confusing that we have both HAVE_EMACS and WITH_EMACS. Should\r
+> this be documented somewhere? Otherwise the patch seems sensible.\r
+>\r
+> See also the discussion at id:528B455A.70200@iki.fi.\r
+\r
+Eventually it's probably good idea to merge HAVE_EMACS to WITH_EMACS but\r
+doing in a good way requires quite a few ./configure changes (and while\r
+doing that one have to check that some consistency is kept).\r
+Eventually it would probably be nice that in case *_EMACS is not set (is 0)\r
+the clean rules stay (provided that those do not require emacs) but\r
+build rules are ifdeffed out...\r
+\r
+In the meantime my patch here maintains status quo where things can be\r
+done in case HAVE_EMACS is set (1) -- emacs is available in the system,\r
+while keeping the cleanup rules in case *_EMACS is not set... and\r
+this patch also fixes the compilation whenever there is no emacs in system.\r
+\r
+I could add short notes of what HAVE_EMACS & WITH_EMACS mean but although\r
+it is bit confusing that we currently have both, those are nevertheless\r
+quite descriptive themselves.\r
+\r
+>\r
+> d\r
+\r
+Tomi\r
+\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r