--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 899B3431E64\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 20:58:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 8b7eqbADJEaD for <notmuch@notmuchmail.org>;\r
+ Sun, 29 Jan 2012 20:58:01 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+ [18.9.25.13])\r
+ by olra.theworths.org (Postfix) with ESMTP id EB386431FBC\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 20:58:00 -0800 (PST)\r
+X-AuditID: 1209190d-b7fbf6d0000008ba-e0-4f262358f901\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+ by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id FB.AA.02234.853262F4; Sun, 29 Jan 2012 23:58:00 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q0U4vx6Q003387; \r
+ Sun, 29 Jan 2012 23:58:00 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0U4vv76029978\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Sun, 29 Jan 2012 23:57:58 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1RrjIj-0000WC-BR; Sun, 29 Jan 2012 23:57:09 -0500\r
+Date: Sun, 29 Jan 2012 23:57:09 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH v2 10/13] emacs: use message ids instead of thread id in\r
+ `notmuch-show-operate-all'\r
+Message-ID: <20120130045709.GN17991@mit.edu>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <1327890382-548-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <1327890382-548-11-git-send-email-dmitry.kurochkin@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1327890382-548-11-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IRYrdT0Y1QVvM3ODJJzOLq1n52i+s3ZzI7\r
+ MHnsnHWX3ePZqlvMAUxRXDYpqTmZZalF+nYJXBlT2veyFHSLVDxoaGVqYJwt0MXIySEhYCLx\r
+ YvkKRghbTOLCvfVsXYxcHEIC+xglLh5bAeVsYJS4suURM0iVkMBJJon29zIQiSWMEouaJ7KC\r
+ JFgEVCVmff7EBGKzCWhIbNu/HGysiIChxK2Lr8CamQWkJb79bgarERbIlNjy7Qk7iM0roCPR\r
+ PmcuI8TQE4wS79vuMkEkBCVOznzCAtGsJXHj30ugOAfYoOX/OEDCnAJeEpufXwa7QVRARWLK\r
+ yW1sExiFZiHpnoWkexZC9wJG5lWMsim5Vbq5iZk5xanJusXJiXl5qUW6Rnq5mSV6qSmlmxhB\r
+ gc0pybuD8d1BpUOMAhyMSjy8Qf9U/YVYE8uKK3MPMUpyMCmJ8rooqfkL8SXlp1RmJBZnxBeV\r
+ 5qQWH2KU4GBWEuF99BOonDclsbIqtSgfJiXNwaIkzquq9c5PSCA9sSQ1OzW1ILUIJivDwaEk\r
+ wXsMZKhgUWp6akVaZk4JQpqJgxNkOA/Q8LMgNbzFBYm5xZnpEPlTjIpS4rwfQBICIImM0jy4\r
+ XljiecUoDvSKMO8LkCoeYNKC634FNJgJaPBzBpCri0sSEVJSDYxuqn3pJxY4mUVEfN0ZHXdC\r
+ yPh6/GHNGt8rgs8E9StkGgW6zptx9iT4qv8Kma++vFZn7Z36/9cexZRL3d6eu2TnxbK/fVe4\r
+ K7plA78fCzWw+u2YenqHw0a2aRv9p/N0zv9xeOXtjpRis3fGb1u3/TyyXeGsCce9jjfZ3hP+\r
+ nb52JZ+rYJVskq8SS3FGoqEWc1FxIgC/vIC/FwMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 04:58:01 -0000\r
+\r
+Quoth Dmitry Kurochkin on Jan 30 at 6:26 am:\r
+> Before the change, `notmuch-show-operate-all' used thread id for\r
+\r
+notmuch-show-tag-all?\r
+\r
+> "notmuch tag" search. This could result in tagging unexpected\r
+> messages that were added to the thread after the notmuch-show buffer\r
+> was created. The patch changes `notmuch-show-operate-all' to use ids\r
+> of shown messages to fix this.\r
+> ---\r
+\r
+If you move this patch before the one that introduces\r
+notmuch-show-tag-all, you could do it this way from the beginning.\r
+\r
+> emacs/notmuch-show.el | 23 ++++++++++++++++++++++-\r
+> 1 files changed, 22 insertions(+), 1 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 0d90c1e..b115a8f 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1170,6 +1170,15 @@ All currently available key bindings:\r
+> (notmuch-show-move-to-message-top)\r
+> t))\r
+> \r
+> +(defun notmuch-show-mapc (function)\r
+> + "Iterate through all messages in the current thread with\r
+> +`notmuch-show-goto-message-next' and call FUNCTION for side\r
+> +effects."\r
+> + (save-excursion\r
+> + (goto-char (point-min))\r
+> + (loop do (funcall function)\r
+> + while (notmuch-show-goto-message-next))))\r
+> +\r
+> ;; Functions relating to the visibility of messages and their\r
+> ;; components.\r
+> \r
+> @@ -1222,6 +1231,18 @@ Some useful entries are:\r
+> "Return the message id of the current message."\r
+> (concat "id:\"" (notmuch-show-get-prop :id) "\""))\r
+> \r
+> +(defun notmuch-show-get-messages-ids ()\r
+> + "Return all message ids of messages in the current thread."\r
+> + (let ((message-ids))\r
+> + (notmuch-show-mapc\r
+> + (lambda () (push (notmuch-show-get-message-id) message-ids)))\r
+> + message-ids))\r
+> +\r
+> +(defun notmuch-show-get-messages-ids-search ()\r
+> + "Return a search string for all message ids of messages in the\r
+> +current thread."\r
+> + (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))\r
+> +\r
+> ;; dme: Would it make sense to use a macro for many of these?\r
+> \r
+> (defun notmuch-show-get-filename ()\r
+> @@ -1494,7 +1515,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+> \r
+> TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+> (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))\r
+> - (apply 'notmuch-tag notmuch-show-thread-id tag-changes)\r
+> + (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)\r
+> (save-excursion\r
+> (goto-char (point-min))\r
+> (loop do (let* ((current-tags (notmuch-show-get-tags))\r
projects / notmuch-archives.git / commitdiff