Re: [PATCH v2] test: add "set -u" to test-lib.sh

diff --git a/b5/8a0d7c35586fc56e5a293efa7e0cb3c62b3c93 b/b5/8a0d7c35586fc56e5a293efa7e0cb3c62b3c93
new file mode 100644 (file)
index 0000000..93344cc
--- /dev/null
+++ b/b5/8a0d7c35586fc56e5a293efa7e0cb3c62b3c93
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 489B76DE014D\r
+ for <notmuch@notmuchmail.org>; Mon, 27 Jun 2016 08:05:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.567\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.567 tagged_above=-999 required=5 tests=[AWL=-0.085,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id jKOa9hPKjCZY for <notmuch@notmuchmail.org>;\r
+ Mon, 27 Jun 2016 08:05:14 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 8ECE56DE00CC\r
+ for <notmuch@notmuchmail.org>; Mon, 27 Jun 2016 08:05:13 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id C06851000E1;\r
+ Mon, 27 Jun 2016 18:04:31 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] test: add "set -u" to test-lib.sh\r
+In-Reply-To: <87a8i64u8o.fsf@maritornes.cs.unb.ca>\r
+References: <1465336777-31225-1-git-send-email-tomi.ollila@iki.fi>\r
+ <87a8i64u8o.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.22+54~gf8fd4ff (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 27 Jun 2016 18:04:31 +0300\r
+Message-ID: <m21t3i7jwg.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 27 Jun 2016 15:05:23 -0000\r
+\r
+On Mon, Jun 27 2016, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> This prohibits unset variables to expand to empty strings.\r
+>> Without this e.g misspelled variables cause unintentional results.\r
+>>\r
+>> Now all the test variables are either initialized, or in case of\r
+>> optional arguments and user-provided environment variables (i.e.\r
+>> when it is not know whethet the variable is set) the form\r
+>> ${variable-} is used.\r
+>>\r
+>> Two unusable lines (leftovers?) in T360-symbol-hiding.sh were removed;\r
+>> this was the only non-lib test code that needed to be edited for this\r
+>> change to work.\r
+>\r
+> Hi Tomi;\r
+>\r
+> I like the idea, but currently I get many test failures with\r
+>\r
+> /test-lib.sh: line 926: test_subtest_missing_external_prereq_: unbound\r
+> variable\r
+\r
+Interesting... have to investigate why I did not get those (IMO I should have...)\r
+\r
+Tomi\r
+\r
+>\r
+> d\r