Re: [PATCH 3/3] lib: Reject multi-message mboxes and deprecate single-message mbox

diff --git a/a5/f8c103f862ffda247482a9b784453e11db02eb b/a5/f8c103f862ffda247482a9b784453e11db02eb
new file mode 100644 (file)
index 0000000..8f651b5
--- /dev/null
+++ b/a5/f8c103f862ffda247482a9b784453e11db02eb
@@ -0,0 +1,122 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 281CE431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 11:57:32 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id WRXGTWETo4JC for <notmuch@notmuchmail.org>;\r
+       Sun, 25 Nov 2012 11:57:31 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1AEB8431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 11:57:31 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id E5D531000E5;\r
+       Sun, 25 Nov 2012 21:57:27 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 3/3] lib: Reject multi-message mboxes and deprecate\r
+       single-message mbox\r
+In-Reply-To: <20121125180524.GL4562@mit.edu>\r
+References: <1353824161-31717-1-git-send-email-amdragon@mit.edu>\r
+       <1353824161-31717-3-git-send-email-amdragon@mit.edu>\r
+       <m2y5hpu82l.fsf@guru.guru-group.fi> <20121125180524.GL4562@mit.edu>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 25 Nov 2012 21:57:27 +0200\r
+Message-ID: <m2ehjh1mmw.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 25 Nov 2012 19:57:32 -0000\r
+\r
+On Sun, Nov 25 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Quoth Tomi Ollila on Nov 25 at  3:26 pm:\r
+>> On Sun, Nov 25 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>>=20\r
+>> > Previously, we would treat multi-message mboxes as one giant email,\r
+>> > which, besides the obvious incorrect indexing, often led to\r
+>> > out-of-memory errors for archival mboxes.  Now we explicitly reject\r
+>> > multi-message mboxes.  For historical reasons, we retain support for\r
+>> > single-message mboxes, but official deprecate this behavior.\r
+>>=20\r
+>>=20\r
+>> The series looks good to me -- but I don't know about deprecating\r
+>> single-message mboxes:\r
+>>=20\r
+>> * If we someday support (read-only?) mbox format, then single-message\r
+>>   mboxes are "normal" again.\r
+>\r
+> If notmuch does gain mbox support, then its handling of single-message\r
+> mboxes will *definitely* change because it will stop doing\r
+> maildir-like things to them (flag sync, moving from new to cur, etc),\r
+> which people may currently be depending on.  This was one of the\r
+> motivations for deprecating the current handling of single-message\r
+> mboxes.\r
+>\r
+>> * Some na=C3=AFve mb2md scripts could leave the 'From ' -line intact: for\r
+>>   example `formail -bz -s head -3 < $MAIL`(*) can be used to demonstrate=\r
+ this\r
+>\r
+> I would call that "buggy", rather than "na=C3=AFve".  ]:--8)\r
+>\r
+>> * Some people may have large collection of single-file messages starting\r
+>>   with 'From ' currently indexed. If those are to be re-indexed later\r
+>>   without "single-message mbox" support that is somewhat of a burden to\r
+>>   the users (**)\r
+>\r
+> That's why this only deprecates them (with a warning) and doesn't drop\r
+> support for them.  The idea is to keep the historical handling for a\r
+> few releases and then we'll have the flexibility to do what we want\r
+> with single-message mboxes (including supporting them as real mbox).\r
+>\r
+> It's probably a good idea to include a script or a wiki pointer for\r
+> fixing single-message mboxes in the NEWS.  As long as the file name is\r
+> kept the same, notmuch won't reindex it.\r
+\r
+Ok, I'm convinced. +1\r
+\r
+Tomi\r
+\r
+>\r
+>> (*) my "mb2md" wannabe does gnus-like "$formail" -bz -R 'From ' X-From-L=\r
+ine: ...\r
+>>=20\r
+>> (**) Something like the following could be used to mangle "single-file m=\r
+boxes"...\r
+>>      find . -type f | xargs perl -e 'foreach (@ARGV) { open IO, "+<", $_=\r
+ or\r
+>>      next; sysread IO, $buf, 5; if ($buf eq "From ") { sysseek IO, 0, 0;\r
+>>      syswrite IO, "Fro:"; }}'=20\r
+>>      This breaks the multi-message mbox nicely... >;)\r
+>>=20\r
+>>=20\r
+>> Tomi\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r