Re: [PATCH] contrib: pick: bugfix use of mini-buffer history

diff --git a/eb/f0a9787952b248a54cdd4b518d6a976dc9a390 b/eb/f0a9787952b248a54cdd4b518d6a976dc9a390
new file mode 100644 (file)
index 0000000..ce90c31
--- /dev/null
+++ b/eb/f0a9787952b248a54cdd4b518d6a976dc9a390
@@ -0,0 +1,85 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 38989431FBD\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Sep 2013 01:36:29 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id J4s1Gt4ioJZA for <notmuch@notmuchmail.org>;\r
+       Sun, 15 Sep 2013 01:36:25 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 92645431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Sep 2013 01:36:25 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 7B2E61000B2;\r
+       Sun, 15 Sep 2013 11:36:19 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: pick: bugfix use of mini-buffer history\r
+In-Reply-To: <1379233173-9812-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1379233173-9812-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 15 Sep 2013 11:36:19 +0300\r
+Message-ID: <m2li2ya3cs.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 15 Sep 2013 08:36:29 -0000\r
+\r
+On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> pick was meant to use the same mini-buffer history but this failed\r
+> because the interactive definition took place before the use search\r
+> mini-buffer history part. Remove the interactive prompt to ensure the\r
+> correct history is used.\r
+> ---\r
+\r
+LGTM.\r
+\r
+Tomi\r
+\r
+>  contrib/notmuch-pick/notmuch-pick.el |    2 +-\r
+>  1 files changed, 1 insertions(+), 1 deletions(-)\r
+>\r
+> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
+> index 01ca4bd..ad85d03 100644\r
+> --- a/contrib/notmuch-pick/notmuch-pick.el\r
+> +++ b/contrib/notmuch-pick/notmuch-pick.el\r
+> @@ -948,7 +948,7 @@ The arguments are:\r
+>    BUFFER-NAME: the name of the buffer to show the pick tree. If\r
+>        it is nil \"*notmuch-pick\" followed by QUERY is used.\r
+>    OPEN-TARGET: If TRUE open the target message in the message pane."\r
+> -  (interactive "sNotmuch pick: ")\r
+> +  (interactive)\r
+>    (if (null query)\r
+>        (setq query (notmuch-read-query "Notmuch pick: ")))\r
+>    (let ((buffer (get-buffer-create (generate-new-buffer-name\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r