Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by default with --client

diff --git a/77/c23c637615ea16ae87d69165072d1f8de18c89 b/77/c23c637615ea16ae87d69165072d1f8de18c89
new file mode 100644 (file)
index 0000000..7e258d1
--- /dev/null
+++ b/77/c23c637615ea16ae87d69165072d1f8de18c89
@@ -0,0 +1,96 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id E85516DE0298\r
+ for <notmuch@notmuchmail.org>; Mon, 28 Sep 2015 04:02:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.107\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.107 tagged_above=-999 required=5 tests=[AWL=0.107]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 3Iz4Xi_Rze5l for <notmuch@notmuchmail.org>;\r
+ Mon, 28 Sep 2015 04:02:16 -0700 (PDT)\r
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 97E6B6DE0173\r
+ for <notmuch@notmuchmail.org>; Mon, 28 Sep 2015 04:02:15 -0700 (PDT)\r
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1ZgWA3-0003ft-Ee; Mon, 28 Sep 2015 10:59:59 +0000\r
+Received: (nullmailer pid 12310 invoked by uid 1000); Mon, 28 Sep 2015\r
+ 10:59:40 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Jani Nikula <jani@nikula.org>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by\r
+ default with --client\r
+In-Reply-To: <m21tepvpm5.fsf@guru.guru-group.fi>\r
+References: <cover.1439629384.git.jani@nikula.org>\r
+ <455026447d3f75b1038ac11cebe734431604be9d.1439629384.git.jani@nikula.org>\r
+ <m21tepvpm5.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.20.2+93~g33c8777 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 28 Sep 2015 07:59:40 -0300\r
+Message-ID: <87wpva3j37.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 28 Sep 2015 11:02:19 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+\r
+> if [ -n "$AUTO_DAEMON" -a -z "$CREATE_FRAME" ]; then\r
+>     echo "$0: --auto-daemon is only applicable with --create-frame." >&2\r
+>     exit 1       \r
+> fi\r
+>\r
+> without this one may execute ./notmuch-emacs-mua --client --auto-daemon\r
+> which yields starting emacs in daemon mode (in this example it is expected\r
+> emacs is not running; otherwise --auto-daemon has no use in this example)\r
+> -- but no ui to that newly-running emacs is provided. Similar behaviour\r
+> can be observed by the following\r
+>\r
+\r
+I think what you propose is fine for a followup patch; note that the\r
+scenario you worry about also needs --client to be a problem. Apparently\r
+nothing is uncontroversial here, but if auto-daemon only works with\r
+create frame, then perhaps the followup would be to have auto-daemon\r
+imply create-frame\r
+\r
+>>  \r
+>> +# Kill the terminal/frame if we're creating one.\r
+>> +if [ -z "$USE_EMACSCLIENT" -o -n "$CREATE_FRAME" -o -n "$NO_WINDOW" ]; then\r
+>> +    ELISP="${ELISP} (setq message-exit-actions (list #'save-buffers-kill-terminal))"\r
+>> +fi\r
+>\r
+> I am not very happy that message-exit-actions was added to $ELISP when\r
+> not using emacsclient; when emacs is started its sole (initial) purpose is\r
+> to serve mail sending (and not lending a frame in some other emacs) -- in\r
+> this case it would be nice to be able to retrieve the sent mail buffer.\r
+\r
+I'm somewhat less sympathetic here. AIUI, the goal of notmuch-emacs-mua\r
+is to provide a drop in tool to replace mutt for sending mail in the\r
+shell or from other programs. In this case, I think the most common\r
+expectation is to terminate after sending mail (e.g. to return use of\r
+the shell to the user, or allow the spawning program to continue).\r
+However, it seems like this would be relatively easy to set up some\r
+customization in notmuch-message-mode so that it could check if running\r
+from the cli, and then either kill-or-not emacs depending on some\r
+variable. So I think I'd like to keep the current behaviour as default,\r
+and make it customizable at the emacs level.\r
+\r