--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 4A747431FAF\r
+ for <notmuch@notmuchmail.org>; Fri, 4 Jul 2014 09:31:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 9Nk4hNV6MFuP for <notmuch@notmuchmail.org>;\r
+ Fri, 4 Jul 2014 09:31:51 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id A9F8B431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 4 Jul 2014 09:31:50 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 2F3A8100033;\r
+ Fri, 4 Jul 2014 19:31:34 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Sebastian Lipp <bacuh@riseup.net>, Jed Brown <jed@59A2.org>,\r
+ Karl Fogel <kfogel@red-bean.com>, Daniel Bergey <bergey@alum.mit.edu>\r
+Subject: Re: [PATCH] emacs: add missing paren to fix defun\r
+ in notmuch-address.el.\r
+In-Reply-To:\r
+ <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+References: <87wqsfik5l.fsf@floss.red-bean.com>\r
+ <87mwtah2hd.fsf@zancas.localnet>\r
+ <877gkeau42.fsf@floss.red-bean.com>\r
+ <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
+ <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
+ <m2hajgxli5.fsf@guru.guru-group.fi>\r
+ <87vc7vgbym.fsf@zancas.localnet>\r
+ <m2ehejykb1.fsf@guru.guru-group.fi>\r
+ <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 04 Jul 2014 19:31:33 +0300\r
+Message-ID: <m2pphlhyqi.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 04 Jul 2014 16:31:56 -0000\r
+\r
+On Fri, Jul 04 2014, Sebastian Lipp <bacuh@riseup.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>> On Tue, Apr 09 2013, David Bremner wrote:\r
+>>> There seems to be a few warnings:\r
+>>>\r
+>>> In notmuch-bbdb/snarf-from:\r
+>>> notmuch-address.el:116:26:Warning: reference to free variable\r
+>>> `bbdb-get-addresses-headers'\r
+>>>\r
+>>> In notmuch-bbdb/snarf-to:\r
+>>> notmuch-address.el:122:29:Warning: reference to free variable\r
+>>> `bbdb-get-addresses-headers'\r
+>>>\r
+>>> In end of data:\r
+>>> notmuch-address.el:143:1:Warning: the following functions are not known to be\r
+>>> defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header\r
+>>>\r
+>>> Do we need a few defvars?\r
+>>\r
+>> For the above set, something like:\r
+>>\r
+>> (defvar bbdb-get-addresses-headers)\r
+>>\r
+>> (declare-function notmuch-show-get-header "notmuch-show" (header &optional props))\r
+>>\r
+>> (declare-function bbdb-get-addresses "bbdb-com" \r
+>> (only-first-address\r
+>> uninteresting-senders\r
+>> get-header-content-function\r
+>> &rest get-header-content-function-args))\r
+>>\r
+>> (declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create))\r
+>\r
+> As I'd like to see this in notmuch I made the change. The patch is\r
+> attached. As it is my first contribution to notmuch at all: Just tell me\r
+> if I'm supposed to do it in any other way.\r
+>\r
+> LG\r
+> basti\r
+\r
+I saved this patch with 'w' in emacs mua -- and have to remove '>' From the\r
+first line so that 'git am' could recognize it. \r
+\r
+There was one whitespace error -- I reapplied with\r
+\r
+git am --whitespace=fix ~/0001-emacs-functions-to-import-sender-or-recipient-into-B.patch\r
+\r
+more inline (in addition to Karl's good comments)\r
+\r
+IMO all of that can be in one patch...\r
+\r
+>>From 522e4294258e6392a02c923b4b7e78a898986fca Mon Sep 17 00:00:00 2001\r
+> From: Daniel Bergey <bergey@alum.mit.edu>\r
+> Date: Mon, 8 Apr 2013 19:55:04 -0500\r
+> Subject: [PATCH] emacs: functions to import sender or recipient into BBDB [v3]\r
+>\r
+>>From a show buffer, notmuch-bbdb/snarf-from imports the sender into\r
+\r
+Interestingly the line above was lost when I applied the patch -- \r
+probably '>From' somehow borke git am... -- should git am be more capable\r
+there (or would the required heuristics pass the tolerance threshold) ?\r
+\r
+> bbdb. notmuch-bbdb/snarf-to imports all recipients. Newly imported\r
+> contacts are reported in the minibuffer / Messages buffer.\r
+>\r
+> Both functions use the BBDB parser to recognize email address formats.\r
+>\r
+> [v3] Fixes a few warnings as suggested by Tomi Ollila in\r
+> id:87vc7vgbym.fsf@zancas.localnet\r
+> [v2] Fixes missing close parenthesis in original.\r
+> Spotted by Karl Fogel <kfogel@red-bean.com>.\r
+> ---\r
+> emacs/notmuch-address.el | 53 ++++++++++++++++++++++++++++++++++++++++++++++++\r
+> 1 file changed, 53 insertions(+)\r
+>\r
+> diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el\r
+> index fa65cd5..ee7b169 100644\r
+> --- a/emacs/notmuch-address.el\r
+> +++ b/emacs/notmuch-address.el\r
+> @@ -113,6 +113,59 @@ to know how address selection is made by default."\r
+> (when (notmuch-address-locate-command notmuch-address-command)\r
+> (notmuch-address-message-insinuate))\r
+> \r
+> +;; functions to add sender / recipients to BBDB\r
+> +\r
+> +(defvar bbdb-get-addresses-headers)\r
+\r
+It would be nice to have comment where bbdb-get-addresses-headers is defined.\r
+\r
+> +\r
+> +(declare-function notmuch-show-get-header "notmuch-show" (header &optional props))\r
+> +\r
+> +(declare-function bbdb-get-addresses "bbdb-com" \r
+> + (only-first-address\r
+> + uninteresting-senders\r
+> + get-header-content-function\r
+> + &rest get-header-content-function-args))\r
+> +\r
+> +(declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create))\r
+> +\r
+> +(defun notmuch-bbdb/snarf-headers (headers)\r
+> + ;; Helper function to avoid code duplication in the two below\r
+> + ;; headers should have the same format as bbdb-get-addresses-headers\r
+> +\r
+> + ;; bbdb-get-addresses reads these\r
+> + ;; Ugh, pass-by-global\r
+\r
+Somehow this comment section looks a bit odd -- is it the empty line there,\r
+or just that (at least part of) it is not docstring.\r
+\r
+> + (let ((addrs (bbdb-get-addresses nil nil 'notmuch-bbdb/get-header-content))\r
+> + (bbdb-get-addresses-headers headers) ; headers to read\r
+> + (bbdb-gag-messages t)) ; suppress m/n processed message)\r
+> + (bbdb-update-records addrs t t)))\r
+> +\r
+> +(defun notmuch-bbdb/snarf-from ()\r
+> + "Import the sender of the current message into BBDB"\r
+> + (interactive)\r
+> + (notmuch-bbdb/snarf-headers\r
+> + (list (assoc 'authors bbdb-get-addresses-headers))))\r
+> +\r
+> +(defun notmuch-bbdb/snarf-to ()\r
+> + "Import all recipients of the current message into BBDB"\r
+> + (interactive)\r
+> + (notmuch-bbdb/snarf-headers\r
+> + (list (assoc 'recipients bbdb-get-addresses-headers))))\r
+> +\r
+> +(defvar notmuch-bbdb/header-by-name\r
+> + ;; both are case sensitive\r
+> + '( ("From" . :From)\r
+> + ("To" . :To)\r
+> + ("CC" . :Cc)\r
+> + ("BCC" . :Bcc)\r
+> + ("Resent-From" . nil)\r
+> + ("Reply-To" . nil)\r
+> + ("Resent-To" . nil)\r
+> + ("Resent-CC" . nil))\r
+> + "Alist for dispatching header symbols as used by notmuch-show-get-header\r
+> +from strings as used by bbdb-get-addresses")\r
+> +\r
+> +(defun notmuch-bbdb/get-header-content (name)\r
+> + (notmuch-show-get-header (cdr (assoc name notmuch-bbdb/header-by-name))))\r
+> +\r
+> ;;\r
+> \r
+> (provide 'notmuch-address)\r
+> -- \r
+> 2.0.1\r
+\r
+Tomi\r
projects / notmuch-archives.git / commitdiff