Re: [PATCH] notmuch dump: default to batch-tag format.

diff --git a/1c/f93dcdec52d1532514ca09b0d9486b87727841 b/1c/f93dcdec52d1532514ca09b0d9486b87727841
new file mode 100644 (file)
index 0000000..80a640f
--- /dev/null
+++ b/1c/f93dcdec52d1532514ca09b0d9486b87727841
@@ -0,0 +1,103 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 17984431FBD\r
+       for <notmuch@notmuchmail.org>; Tue, 21 Jan 2014 05:59:00 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Z9tQb5JFuYdf for <notmuch@notmuchmail.org>;\r
+       Tue, 21 Jan 2014 05:58:52 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 651A2431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 21 Jan 2014 05:58:52 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 7F0F51000B3;\r
+       Tue, 21 Jan 2014 15:58:43 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] notmuch dump: default to batch-tag format.\r
+In-Reply-To: <1390311688-1491-1-git-send-email-david@tethera.net>\r
+References: <1390311688-1491-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.17+34~g98b959f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 21 Jan 2014 15:58:43 +0200\r
+Message-ID: <m24n4xo2r0.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 21 Jan 2014 13:59:00 -0000\r
+\r
+On Tue, Jan 21 2014, david@tethera.net wrote:\r
+\r
+> From: David Bremner <david@tethera.net>\r
+>\r
+> Although we didn't formally deprecate the old format, the new one has\r
+> been available for a year.\r
+> ---\r
+>  NEWS           | 10 ++++++++++\r
+>  notmuch-dump.c |  2 +-\r
+>  2 files changed, 11 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/NEWS b/NEWS\r
+> index 28788d8..bdb248e 100644\r
+> --- a/NEWS\r
+> +++ b/NEWS\r
+> @@ -1,3 +1,13 @@\r
+> +Notmuch 0.18 (2014-xx-xx)\r
+> +=========================\r
+\r
+I tried to advocate Notmuch 0.18 (UNRELEASED) during last development\r
+cycle -- in followu ========================= p patch (if any -- \r
+with manpage change) this change could also be made.\r
+\r
+> +\r
+> +Command-Line Interface\r
+> +----------------------\r
+> +\r
+> +`notmuch dump` now defaults to `batch-tag` format.\r
+> +\r
+> +  The old format is still available with `--format=sup`.\r
+> +\r
+>  Notmuch 0.17 (2013-12-30)\r
+>  =========================\r
+>  \r
+> diff --git a/notmuch-dump.c b/notmuch-dump.c\r
+> index f8edda7..158142f 100644\r
+> --- a/notmuch-dump.c\r
+> +++ b/notmuch-dump.c\r
+> @@ -40,7 +40,7 @@ notmuch_dump_command (notmuch_config_t *config, int argc, char *argv[])\r
+>      char *output_file_name = NULL;\r
+>      int opt_index;\r
+>  \r
+> -    int output_format = DUMP_FORMAT_SUP;\r
+> +    int output_format = DUMP_FORMAT_BATCH_TAG;\r
+\r
+This part looks good.\r
+\r
+>  \r
+>      notmuch_opt_desc_t options[] = {\r
+>      { NOTMUCH_OPT_KEYWORD, &output_format, "format", 'f',\r
+> -- \r
+\r
+Tomi\r