Re: [PATCH v2 0/9] emacs: Unify common key bindings and lots more

diff --git a/fa/c07d8f388da541c03fd01e50c808e13a79e2a5 b/fa/c07d8f388da541c03fd01e50c808e13a79e2a5
new file mode 100644 (file)
index 0000000..73d0d83
--- /dev/null
+++ b/fa/c07d8f388da541c03fd01e50c808e13a79e2a5
@@ -0,0 +1,145 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D72F0431FDD\r
+       for <notmuch@notmuchmail.org>; Thu,  5 Sep 2013 02:27:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id VP6FhZqdq3P7 for <notmuch@notmuchmail.org>;\r
+       Thu,  5 Sep 2013 02:27:52 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B901F431FDB\r
+       for <notmuch@notmuchmail.org>; Thu,  5 Sep 2013 02:27:51 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VHVqv-0004lu-VU; Thu, 05 Sep 2013 10:27:50 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VHVqv-0002fT-JS; Thu, 05 Sep 2013 10:27:49 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/9] emacs: Unify common key bindings and lots more\r
+In-Reply-To: <1378244725-18846-1-git-send-email-amdragon@mit.edu>\r
+References: <1378244725-18846-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+269~g01f5508 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 05 Sep 2013 10:27:48 +0100\r
+Message-ID: <87a9jrlisr.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: a3869301cd9ea9a0870e2c28bb776844 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.0 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 05 Sep 2013 09:27:58 -0000\r
+\r
+\r
+LGTM +1. (The defcustom is a nice addition)\r
+\r
+Mark\r
+\r
+On Tue, 03 Sep 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> This is v2 of id:1377793557-28878-1-git-send-email-amdragon@mit.edu.\r
+> This fixes a problem found by Jani where notmuch-hello would reset\r
+> point placement when refreshing in Emacs 24.  It also inverts the\r
+> sense of notmuch-hello-auto-refresh and makes it a defcustom\r
+> (originally I'd intended notmuch-hello-inhibit-auto-refresh for\r
+> internal use only, but both Mark and Jani expressed interest in\r
+> setting it).\r
+>\r
+> The diff from v1 follows\r
+>\r
+> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> index 1d6c3a2..55c416a 100644\r
+> --- a/emacs/notmuch-hello.el\r
+> +++ b/emacs/notmuch-hello.el\r
+> @@ -232,6 +232,11 @@ supported for \"Customized queries section\" items."\r
+>          notmuch-hello-query-section\r
+>          (function :tag "Custom section"))))\r
+>  \r
+> +(defcustom notmuch-hello-auto-refresh t\r
+> +  "Automatically refresh when returning to the notmuch-hello buffer."\r
+> +  :group 'notmuch-hello\r
+> +  :type 'boolean)\r
+> +\r
+>  (defvar notmuch-hello-hidden-sections nil\r
+>    "List of sections titles whose contents are hidden")\r
+>  \r
+> @@ -478,9 +483,6 @@ Such a list can be computed with `notmuch-hello-query-counts'."\r
+>    ;; Lazy - rebuild everything.\r
+>    (notmuch-hello no-display))\r
+>  \r
+> -(defvar notmuch-hello-inhibit-auto-refresh nil\r
+> -  "Don't refresh notmuch-hello on window configuration changes.")\r
+> -\r
+>  (defun notmuch-hello-window-configuration-change ()\r
+>    "Hook function to update the hello buffer when it is switched to."\r
+>    (let ((hello-buf (get-buffer "*notmuch-hello*"))\r
+> @@ -501,8 +503,11 @@ Such a list can be computed with `notmuch-hello-query-counts'."\r
+>          ;; is currently visible, was not visible on the last\r
+>          ;; configuration change, and this is not a new window)\r
+>          (setq do-refresh t)))))\r
+> -    (when (and do-refresh (not notmuch-hello-inhibit-auto-refresh))\r
+> -      (notmuch-hello t))\r
+> +    (when (and do-refresh notmuch-hello-auto-refresh)\r
+> +      ;; Refresh hello as soon as we get back to redisplay.  On Emacs\r
+> +      ;; 24, we can't do it right here because something in this\r
+> +      ;; hook's call stack overrides hello's point placement.\r
+> +      (run-at-time nil nil #'notmuch-hello t))\r
+>      (when (null hello-buf)\r
+>        ;; Clean up hook\r
+>        (remove-hook 'window-configuration-change-hook\r
+> @@ -785,14 +790,15 @@ following:\r
+>  \r
+>    ;; This may cause a window configuration change, so if the\r
+>    ;; auto-refresh hook is already installed, avoid recursive refresh.\r
+> -  (let ((notmuch-hello-inhibit-auto-refresh t))\r
+> +  (let ((notmuch-hello-auto-refresh nil))\r
+>      (if no-display\r
+>      (set-buffer "*notmuch-hello*")\r
+>        (switch-to-buffer "*notmuch-hello*")))\r
+>  \r
+>    ;; Install auto-refresh hook\r
+> -  (add-hook 'window-configuration-change-hook\r
+> -        #'notmuch-hello-window-configuration-change)\r
+> +  (when notmuch-hello-auto-refresh\r
+> +    (add-hook 'window-configuration-change-hook\r
+> +          #'notmuch-hello-window-configuration-change))\r
+>  \r
+>    (let ((target-line (line-number-at-pos))\r
+>      (target-column (current-column))\r
+>\r
+\r