Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature

diff --git a/06/3beaf3e07d562981d5aaf346003ed7874b8204 b/06/3beaf3e07d562981d5aaf346003ed7874b8204
new file mode 100644 (file)
index 0000000..1e85b02
--- /dev/null
+++ b/06/3beaf3e07d562981d5aaf346003ed7874b8204
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1EE6A431FC3\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 01:56:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 1lic-FtOHtVp for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Oct 2014 01:56:55 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AEB78431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 01:56:55 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Xahcc-0007mr-UE; Sun, 05 Oct 2014 05:56:54 -0300\r
+Received: (nullmailer pid 14365 invoked by uid 1000); Sun, 05 Oct 2014\r
+       08:56:44 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 08/11] lib: Implement upgrade to ghost messages feature\r
+In-Reply-To: <1412345958-8278-9-git-send-email-aclements@csail.mit.edu>\r
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+       <1412345958-8278-9-git-send-email-aclements@csail.mit.edu>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 05 Oct 2014 10:56:44 +0200\r
+Message-ID: <87d2a6q4hf.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 Oct 2014 08:56:59 -0000\r
+\r
+Austin Clements <aclements@csail.mit.edu> writes:\r
+> +    if (new_features & NOTMUCH_FEATURE_GHOSTS) {\r
+> +    t_end = db->metadata_keys_end ("thread_id_");\r
+> +    for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t)\r
+> +        ++total;\r
+> +    }\r
+\r
+It would be nice to have the comment below, or something like it, for\r
+the loop above.\r
+\r
+> +    /* Perform metadata upgrades. */\r
+> +\r
+> +    /* Prior to NOTMUCH_FEATURE_GHOSTS, thread IDs for missing\r
+> +     * messages were stored as database metadata. Change these to\r
+> +     * ghost messages.\r
+> +     */\r