Re: [PATCH 00/11] Fix search tagging races

diff --git a/ed/fc1a179e48d65756a0e9230f294e327222246d b/ed/fc1a179e48d65756a0e9230f294e327222246d
new file mode 100644 (file)
index 0000000..123953e
--- /dev/null
+++ b/ed/fc1a179e48d65756a0e9230f294e327222246d
@@ -0,0 +1,115 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 01447431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  8 Oct 2013 00:56:39 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.401\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.401 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id yt2FGVfMJXqx for <notmuch@notmuchmail.org>;\r
+       Tue,  8 Oct 2013 00:56:33 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 14C77431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  8 Oct 2013 00:56:33 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VTS9f-0003BG-A0; Tue, 08 Oct 2013 08:56:31 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VTS9f-0000Yy-0h; Tue, 08 Oct 2013 08:56:31 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] Fix search tagging races\r
+In-Reply-To: <1381185201-25197-1-git-send-email-amdragon@mit.edu>\r
+References: <1381185201-25197-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+334~gafd5c6a (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 08 Oct 2013 08:56:30 +0100\r
+Message-ID: <87ob70kxg1.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: f34cb0042d00c0f72f1fc0c89e44afb0 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.6\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.6 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  1.0 FREEMAIL_REPLY From and body contain different freemails\r
+       * -0.4 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 08 Oct 2013 07:56:40 -0000\r
+\r
+\r
+Hello\r
+\r
+It's great that this might finally get done. But there is one problem\r
+currently.\r
+\r
+If you open a large search buffer and then do *-<tab> it will die as the\r
+tagging routine runs notmuch search to find a completion-list for the\r
+tag. (it runs notmuch search --output=tags <query>)\r
+\r
+We could just return all tags in this case. Or we could do something\r
+like the series\r
+id:1354263691-19715-1-git-send-email-markwalters1009@gmail.com\r
+which makes completion happen based on the tags visible to the user, not\r
+the tags actually in the database.\r
+\r
+There is also a little discussion of this in my earlier attempt at\r
+fixing this: eg id:87mwy4smad.fsf@qmul.ac.uk\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+On Mon, 07 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> I was hacking on undo support for notmuch-emacs and sort of\r
+> accidentally wrote this instead.  This series fixes a set of\r
+> well-known races where tagging from search-mode unexpectedly affects\r
+> messages that arrived after the search was performed (and hence the\r
+> user doesn't know they're tagging them).  We've attacked this a few\r
+> times before, but have always run up against something that was\r
+> missing.  It turns out the pieces are finally all in place.\r
+>\r
+> The first five patches just clean various things up in preparation.\r
+> Patches 6 and 7 add support for tagging large queries, which would\r
+> otherwise become a problem when later patches start using explicit\r
+> message ID-based queries for tagging.  The remaining four patches\r
+> actually fix the search tagging races using explicit message ID-based\r
+> queries.\r
+>\r
+> It's a fairly long series, but none of the patches are very big.\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r