Re: [PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags of all matching...

diff --git a/1d/8a96b3045b0c978fb449e44b0ea2fbc9b71588 b/1d/8a96b3045b0c978fb449e44b0ea2fbc9b71588
new file mode 100644 (file)
index 0000000..8716640
--- /dev/null
+++ b/1d/8a96b3045b0c978fb449e44b0ea2fbc9b71588
@@ -0,0 +1,104 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 23307431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 22 Feb 2012 10:55:35 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id S7w55-RCjwpO for <notmuch@notmuchmail.org>;\r
+       Wed, 22 Feb 2012 10:55:34 -0800 (PST)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 689C6431FAE   for <notmuch@notmuchmail.org>; Wed, 22 Feb 2012 10:55:34 -0800\r
+ (PST)\r
+Received: by wgbdt12 with SMTP id dt12so318948wgb.2\r
+       for <notmuch@notmuchmail.org>; Wed, 22 Feb 2012 10:55:33 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of pieter@praet.org designates\r
+       10.180.87.8 as permitted sender) client-ip=10.180.87.8; \r
+Authentication-Results: mr.google.com;\r
+       spf=pass (google.com: domain of pieter@praet.org\r
+       designates 10.180.87.8 as permitted sender)\r
+       smtp.mail=pieter@praet.org\r
+Received: from mr.google.com ([10.180.87.8])\r
+       by 10.180.87.8 with SMTP id t8mr39272699wiz.15.1329936933295 (num_hops\r
+       = 1); Wed, 22 Feb 2012 10:55:33 -0800 (PST)\r
+Received: by 10.180.87.8 with SMTP id t8mr32595739wiz.15.1329936933127;\r
+       Wed, 22 Feb 2012 10:55:33 -0800 (PST)\r
+Received: from localhost ([109.131.181.26])\r
+       by mx.google.com with ESMTPS id fl2sm74969282wib.4.2012.02.22.10.55.32\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 22 Feb 2012 10:55:32 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags\r
+       of all matching messages"\r
+In-Reply-To: <m2zkcev8dt.fsf@guru.guru-group.fi>\r
+References: <1310313335-4159-1-git-send-email-pieter@praet.org>\r
+       <1329683908-5435-1-git-send-email-pieter@praet.org>\r
+       <1329683908-5435-5-git-send-email-pieter@praet.org>\r
+       <m2zkcev8dt.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Wed, 22 Feb 2012 19:53:20 +0100\r
+Message-ID: <87ehtm8ztr.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQmgrNyZPWaew6l6ia9kRZybHLIz2f2MFpD8lR7wPbQD2maESNp8Fl9r0OlQHc+rHINZA7fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 22 Feb 2012 18:55:35 -0000\r
+\r
+On Sun, 19 Feb 2012 23:08:30 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Sun, 19 Feb 2012 21:38:28 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> > `notmuch-search-tag-all' (bound to "*") adds and removes tags\r
+> > to/from all messages which match the query used to populate the\r
+> > current search buffer.\r
+> > ---\r
+> >  test/emacs |   32 ++++++++++++++++++++++++++++++++\r
+> >  1 files changed, 32 insertions(+), 0 deletions(-)\r
+> > \r
+> \r
+> [ ... ]\r
+> \r
+> > +old_tag_count_1=$(notmuch count tag:"${old_tag}" "${filter}")\r
+> > +new_tag_count_1=$(notmuch count tag:"${new_tag}" "${filter}")\r
+> > +test "${old_tag_count_1}" == "0" && old_tag_count_1="Need 1+ matches!"\r
+> > +test "${new_tag_count_1}" == "0" || new_tag_count_1="Need 0 matches!"\r
+> > +# Change tags of all matching messages and get tag counts\r
+> > +test_emacs "(notmuch-search \"tag:${old_tag} ${filter}\")\r
+> \r
+> Small nit: string equality comparison operator is '='. \r
+> Use  grep '==' test/*  to confirm (or man test).\r
+>\r
+\r
+Argh...  Nice catch!\r
+\r
+\r
+> [ ... ]\r
+> \r
+> Tomi\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r