Re: [PATCH 2/4] test: added --stderr=FILE tests

diff --git a/69/c0587bd58eff1090f20af55f7266e0373eefea b/69/c0587bd58eff1090f20af55f7266e0373eefea
new file mode 100644 (file)
index 0000000..8115d7e
--- /dev/null
+++ b/69/c0587bd58eff1090f20af55f7266e0373eefea
@@ -0,0 +1,107 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BA2EF431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 25 May 2013 04:03:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id TGXnN+AYrOQn for <notmuch@notmuchmail.org>;\r
+       Sat, 25 May 2013 04:02:56 -0700 (PDT)\r
+Received: from mail-la0-f43.google.com (mail-la0-f43.google.com\r
+       [209.85.215.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 18D27431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 25 May 2013 04:02:55 -0700 (PDT)\r
+Received: by mail-la0-f43.google.com with SMTP id ez20so5272674lab.30\r
+       for <notmuch@notmuchmail.org>; Sat, 25 May 2013 04:02:53 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type:x-gm-message-state;\r
+       bh=1oZgPVQUrKFpadvW3h/6FjtwA0AvwGLHP9ar3Z+RwSk=;\r
+       b=k+LzhXuqugZQPbZJ7QGrCldLyB/1F62PYHcZtGxwVvoxMCQSQkQ2/boeDgXBP1uoq3\r
+       JvgObgPHoQgvTezDZ0zdvUIjHDrxFahO1K1EdE0JHcFUMfNy9rDLosex88zrdCMCRRku\r
+       fjrLIVHBiRZl58OYROluvxqFnyRoTQ/T9HbgkiBrNFzf6Y/SvSO6mgcgZFU0ti5gMe3I\r
+       CjBMfejmJq3jo5mEKbBwr6R8rSKYqcTa23Uz4aqYU7EMJ17bT+MSBFKgQWfi7OgOn7Gx\r
+       fsB7RrhIzlAaXloeKREptjHPIc+4IcKFnZnn3aSeOMJtWWuQvKrPlLJ/d58gcjpUBbnX\r
+       MSUA==\r
+X-Received: by 10.152.116.7 with SMTP id js7mr5940109lab.7.1369479771989;\r
+       Sat, 25 May 2013 04:02:51 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c376-211.dhcp.inet.fi.\r
+       [88.195.118.211])\r
+       by mx.google.com with ESMTPSA id uo8sm6183974lbb.5.2013.05.25.04.02.50\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sat, 25 May 2013 04:02:50 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/4] test: added --stderr=FILE tests\r
+In-Reply-To: <87k3mo3iv8.fsf@nikula.org>\r
+References: <1369332362-4719-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1369332362-4719-2-git-send-email-tomi.ollila@iki.fi>\r
+       <87k3mo3iv8.fsf@nikula.org>\r
+User-Agent: Notmuch/0.15.2+87~gc69f540 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 25 May 2013 14:02:41 +0300\r
+Message-ID: <87hahr1fvy.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Gm-Message-State:\r
+ ALoCoQkTwNeI6EiJGoQZ1JTfDJBH+xBaJDpXF1giyw5/umWiK9ISkkJYo7lX3v1DLmbbSUavgV5H\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 25 May 2013 11:03:06 -0000\r
+\r
+On Fri, 24 May 2013, Jani Nikula <jani@nikula.org> wrote:\r
+> On Thu, 23 May 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+>> --stderr=FILE tests were added to test/help-test as it is the one\r
+>> doing most global option testing. Also, it was simplest to test\r
+>> this new option using `notmuch help` command.\r
+>> ---\r
+>>\r
+>> In the future this file (help-test) could be renamed and used in\r
+>> more generic "global option" testing\r
+>>\r
+>>  test/help-test | 10 ++++++++++\r
+>>  1 file changed, 10 insertions(+)\r
+>>\r
+>> diff --git a/test/help-test b/test/help-test\r
+>> index f7df725..8b77931 100755\r
+>> --- a/test/help-test\r
+>> +++ b/test/help-test\r
+>> @@ -9,4 +9,14 @@ test_expect_success 'notmuch help' 'notmuch help'\r
+>>  test_expect_success 'notmuch help tag' 'notmuch help tag'\r
+>>  test_expect_success 'notmuch --version' 'notmuch --version'\r
+>>  \r
+>> +test_begin_subtest "notmuch --stderr=stderr help %"\r
+>> +notmuch --stderr=stderr help %\r
+>> +test_expect_equal "$(cat stderr)" "\r
+>> +Sorry, % is not a known command. There's not much I can do to help."\r
+>> +\r
+>> +test_begin_subtest "notmuch --stderr=- help %"\r
+>> +notmuch --stderr=stderr help %\r
+>\r
+> Leftover line from copy-paste?\r
+\r
+Apart from this, the whole series LGTM.\r
+\r
+BR,\r
+Jani.\r