git-stash: use stdout instead of stderr for non error messages

Some scripts and libraries check stderr to detect a failing command,
instead of checking the exit code.  Because the output from git-status
is not primarily for machine consumption, it would not hurt to send
these messages to stdout instead and it will make it easier to drive
the command for such callers.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/git-stash.sh b/git-stash.sh
index 06cb177ec6c10d21f128390edc5bfedfa05db9a9..4d5e5c0be7941b48fcf33364ee36d08d626ea487 100755 (executable)
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -86,7 +86,7 @@ save_stash () {
 
        if no_changes
        then
-               echo >&2 'No local changes to save'
+               echo 'No local changes to save'
                exit 0
        fi
        test -f "$GIT_DIR/logs/$ref_stash" ||
@@ -99,7 +99,7 @@ save_stash () {
 
        git update-ref -m "$stash_msg" $ref_stash $w_commit ||
                die "Cannot save the current status"
-       printf >&2 'Saved working directory and index state "%s"\n' "$stash_msg"
+       printf 'Saved working directory and index state "%s"\n' "$stash_msg"
 }
 
 have_stash () {
@@ -229,7 +229,7 @@ create)
        if test $# -eq 0
        then
                save_stash &&
-               echo >&2 '(To restore them type "git stash apply")' &&
+               echo '(To restore them type "git stash apply")' &&
                git-reset --hard
        else
                usage