--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id B851E431FDB\r
+ for <notmuch@notmuchmail.org>; Fri, 31 May 2013 16:33:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id pc9JJClSSXpt for <notmuch@notmuchmail.org>;\r
+ Fri, 31 May 2013 16:33:18 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu\r
+ [18.9.25.15])\r
+ by olra.theworths.org (Postfix) with ESMTP id BF8F3431FBD\r
+ for <notmuch@notmuchmail.org>; Fri, 31 May 2013 16:33:18 -0700 (PDT)\r
+X-AuditID: 1209190f-b7f256d000005616-0d-51a9333e05fd\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+ by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 9A.0F.22038.E3339A15; Fri, 31 May 2013 19:33:18 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r4VNXHKT009843; \r
+ Fri, 31 May 2013 19:33:17 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r4VNXF9U001980\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Fri, 31 May 2013 19:33:16 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1UiYot-0005GY-9D; Fri, 31 May 2013 19:33:15 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org,\r
+ Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+Subject: Re: [PATCH v3 0/5] emacs: show: lazy handling of hidden parts\r
+In-Reply-To: <1370024806-6616-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1370024806-6616-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+83~g8bee3c4 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Fri, 31 May 2013 19:33:15 -0400\r
+Message-ID: <87wqqe2090.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsUixG6nrmtnvDLQYMEjfosje2axW6yey2Nx\r
+ /eZMZgdmj52z7rJ7PFt1i9mj6cdi1gDmKC6blNSczLLUIn27BK6MlnU9TAVTBCt2NzWwNDA+\r
+ 4u1i5OSQEDCRuNX8jxXCFpO4cG89WxcjF4eQwD5Gie9du5khnI2MEu9/bGWFcE4zSVy/epsJ\r
+ wlnCKPHkw1QWkH42AQ2JbfuXM4LYIgJlElumz2ICsZkFdCRO7N4GFhcWcJP4fKeNDcTmFPCU\r
+ OHlqI5gtJOAhcXn/drA7RAUSJFbePQFWzyKgKnHyejeYzQt06/0zDawQtqDEyZlPWCDma0nc\r
+ +PeSaQKj4CwkqVlIUgsYmVYxyqbkVunmJmbmFKcm6xYnJ+blpRbpmujlZpbopaaUbmIEhS+n\r
+ JP8Oxm8HlQ4xCnAwKvHwdqxaESjEmlhWXJl7iFGSg0lJlLdefWWgEF9SfkplRmJxRnxRaU5q\r
+ 8SFGCQ5mJRHe/DlA5bwpiZVVqUX5MClpDhYlcd6rKTf9hQTSE0tSs1NTC1KLYLIyHBxKErxp\r
+ RkBDBYtS01Mr0jJzShDSTBycIMN5gIZ3gtTwFhck5hZnpkPkTzEqSonzuoAkBEASGaV5cL2w\r
+ 9PKKURzoFWFeH5AqHmBqgut+BTSYCWjwE+vlIINLEhFSUg2Mdq+LZkrf3/og/BNn/dUyRwWH\r
+ pO2fPIL3e7zPUP+kErpmx9dHDozq1v8cV0Y9+mN1c7J7t27JJ+YA/6u7mXpVohaf+Bt2amWa\r
+ y/Xr997//HPzsDeTjSlbVVPkhdZ4T42UwsV8uhHyZ5qM+1mUVq1IbuWJM+kyOeh6ObXsVuvB\r
+ xGNpIWaz1JcrsRRnJBpqMRcVJwIAX5IsGgoDAAA=\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 31 May 2013 23:33:25 -0000\r
+\r
+LGTM other than the tiny things I mentioned. As Mark says, there are a\r
+lot of paths through this code (though he did a good job of minimizing\r
+them), so it'll need some testing. Of course, what better place to test\r
+than git master?\r
+\r
+As a heads up, I think this will have a trivial conflict with\r
+id:"1369876428-13537-4-git-send-email-amdragon@mit.edu", which is\r
+currently in the ready queue.\r
+\r
+On Fri, 31 May 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> This is a substantially reworked version of\r
+> id:1369555061-21361-1-git-send-email-markwalters1009@gmail.com\r
+> attempting to answer the (very constructive) criticism of Austin.\r
+>\r
+> The changes are: move the insert-part-header call from the\r
+> insert-part-text/plain function to insert-bodypart in line with all\r
+> the other part insertion functions. \r
+>\r
+> The other change in patch 2 is that we no longer need to pass\r
+> declared-type down to the part insertion functions so we remove this\r
+> argument.\r
+>\r
+> The actual invisibility code has been substantially reworked. There\r
+> were two main aims: to remove the insertion of dummy text and to make\r
+> sure that toggling a lazy-part which cannot be rendered automatically\r
+> calls the default action for such a part (e.g. saving or viewing).\r
+>\r
+> I have split this code into 3 pieces: two pieces of simple code\r
+> movement as preparation and then the new code to do the actual\r
+> lazy part handling.\r
+>\r
+> All tests pass and everything I can think of to try works (viewing\r
+> pdf, lazy rendered html, lazy rendered pdf, toggling all types,\r
+> repeated toggling) but there are a lot of cases so testing is\r
+> especially helpful.\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+>\r
+>\r
+>\r
+> Mark Walters (5):\r
+> emacs: show: fake wash parts are handled at insert-bodypart level\r
+> emacs: show: move the insertion of the header button to the top level\r
+> emacs: show: pass button to create-overlays\r
+> emacs: show: modify the way hidden state is recorded.\r
+> emacs: show: implement lazy hidden part handling\r
+>\r
+> emacs/notmuch-show.el | 183 +++++++++++++++++++++++++++++--------------------\r
+> 1 file changed, 107 insertions(+), 76 deletions(-)\r
+>\r
+> -- \r
+> 1.7.10.4\r
projects / notmuch-archives.git / commitdiff