[PATCH] notmuch-dump: use fsync instead of fdatasync

diff --git a/6a/d0d5dc7abf228d557779010b4f19b853b3e843 b/6a/d0d5dc7abf228d557779010b4f19b853b3e843
new file mode 100644 (file)
index 0000000..44f140d
--- /dev/null
+++ b/6a/d0d5dc7abf228d557779010b4f19b853b3e843
@@ -0,0 +1,71 @@
+Return-Path: <bremner@tesseract.cs.unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id DEA48431FBF\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 04:58:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id bg+ivVVaCJJY for <notmuch@notmuchmail.org>;\r
+       Thu,  8 May 2014 04:58:16 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0D020431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 04:58:16 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <bremner@tesseract.cs.unb.ca>)\r
+       id 1WiMx8-00070g-CL; Thu, 08 May 2014 11:57:30 +0000\r
+Received: (nullmailer pid 18544 invoked by uid 1000); Thu, 08 May 2014\r
+       11:57:12 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] notmuch-dump: use fsync instead of fdatasync\r
+Date: Thu,  8 May 2014 20:57:07 +0900\r
+Message-Id: <1399550227-18488-1-git-send-email-david@tethera.net>\r
+X-Mailer: git-send-email 1.9.2\r
+In-Reply-To: <20140507171835.GA27619@mit.edu>\r
+References: <20140507171835.GA27619@mit.edu>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 May 2014 11:58:21 -0000\r
+\r
+Since the file size will have changed, there is no performance benefit\r
+to calling fdatasync.  Somewhat surprisingly, using fdatasync\r
+apparently causes portability problems on FreeBSD.\r
+---\r
+ notmuch-dump.c | 2 +-\r
+ 1 file changed, 1 insertion(+), 1 deletion(-)\r
+\r
+diff --git a/notmuch-dump.c b/notmuch-dump.c\r
+index 2849eab..887a208 100644\r
+--- a/notmuch-dump.c\r
++++ b/notmuch-dump.c\r
+@@ -169,7 +169,7 @@ notmuch_database_dump (notmuch_database_t *notmuch,\r
+     }\r
+ \r
+     if (output_file_name) {\r
+-      ret = fdatasync (outfd);\r
++      ret = fsync (outfd);\r
+       if (ret) {\r
+           fprintf (stderr, "Error syncing %s to disk: %s\n",\r
+                    name_for_error, strerror (errno));\r
+-- \r
+1.9.2\r
+\r