Re: [PATCH] doc: Fix parallel build of roff files
authorAustin Clements <amdragon@MIT.EDU>
Sat, 10 May 2014 16:02:30 +0000 (12:02 +2000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:02:36 +0000 (10:02 -0800)
86/d0939c5332635c0cd21e053b2dc65b478251d4 [new file with mode: 0644]

diff --git a/86/d0939c5332635c0cd21e053b2dc65b478251d4 b/86/d0939c5332635c0cd21e053b2dc65b478251d4
new file mode 100644 (file)
index 0000000..4aee892
--- /dev/null
@@ -0,0 +1,109 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 32930431FC0\r
+       for <notmuch@notmuchmail.org>; Sat, 10 May 2014 09:02:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 70PevnmNGvFv for <notmuch@notmuchmail.org>;\r
+       Sat, 10 May 2014 09:02:39 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu\r
+       [18.9.25.13])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7617B431FBF\r
+       for <notmuch@notmuchmail.org>; Sat, 10 May 2014 09:02:39 -0700 (PDT)\r
+X-AuditID: 1209190d-f798f6d000000c3b-e2-536e4d9dffc2\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+       (using TLS with cipher AES256-SHA (256/256 bits))\r
+       (Client did not present a certificate)\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id EC.7C.03131.D9D4E635; Sat, 10 May 2014 12:02:37 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id s4AG2aat017307; \r
+       Sat, 10 May 2014 12:02:37 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s4AG2X2l020911\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Sat, 10 May 2014 12:02:35 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1Wj9jL-0000oN-Sz; Sat, 10 May 2014 12:02:32 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Subject: Re: [PATCH] doc: Fix parallel build of roff files\r
+In-Reply-To: <20140510151833.GR28634@odin.tremily.us>\r
+References: <1397766897-14475-1-git-send-email-amdragon@mit.edu>\r
+       <20140510151833.GR28634@odin.tremily.us>\r
+User-Agent: Notmuch/0.18~rc1+6~gecef282 (http://notmuchmail.org) Emacs/23.4.1\r
+       (i486-pc-linux-gnu)\r
+Date: Sat, 10 May 2014 12:02:30 -0400\r
+Message-ID: <874n0xoc4p.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsUixG6nojvXNy/YYP1uU4vrN2cyW1xZc57d\r
+       gcnj2apbzB67v/9kCWCK4rJJSc3JLEst0rdL4Mo43iZY0MRZcfHOBLYGxrnsXYycHBICJhIH\r
+       Pr5ihLDFJC7cW8/WxcjFISQwm0li8c0TLBDORkaJVwf6mEGqhAROM0k861CESCxhlDg97QMb\r
+       SIJNQENi2/7lYKNEBNQlNqxYARZnFpCW+Pa7mQnEFhawkjjRMw3M5hQwlWg/+IUdYmimxPSO\r
+       r2C2qECixMlVj8BqWARUJY5c3AJkc3DwAp16YakkSJhXQFDi5MwnLBDjtSRu/HvJNIFRcBaS\r
+       1CwkqQWMTKsYZVNyq3RzEzNzilOTdYuTE/PyUot0jfRyM0v0UlNKNzGCwpRTkncH47uDSocY\r
+       BTgYlXh4C97mBAuxJpYVV+YeYpTkYFIS5fV2ywsW4kvKT6nMSCzOiC8qzUktPsQowcGsJMK7\r
+       XRcox5uSWFmVWpQPk5LmYFES531rbRUsJJCeWJKanZpakFoEk5Xh4FCS4P3tDdQoWJSanlqR\r
+       lplTgpBm4uAEGc4DNPwHSA1vcUFibnFmOkT+FKMux4Ifa1qYhFjy8vNSpcR5l4IUCYAUZZTm\r
+       wc2BpZdXjOJAbwnz/gGp4gGmJrhJr4CWMAEt8dXPBllSkoiQkmpg5DJZajvF998++Rees4uC\r
+       rvkfDlzAGDJPIl56l9AviQlS/VcFW00Z3q73jDU5JJh5/NsO1midHSwRfd8zqo63fnmzd37Q\r
+       0qdlLBKzsq5OO7hiz+F3HSziwY9ndNr4Hpbat7iSaWnbi6znPMuZfop+uVz/6KV/ZF7K7Mmc\r
+       y5g8F3BfMpoWOX+7qhJLcUaioRZzUXEiANZtlr8KAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 10 May 2014 16:02:48 -0000\r
+\r
+On Sat, 10 May 2014, "W. Trevor King" <wking@tremily.us> wrote:\r
+> On Thu, Apr 17, 2014 at 04:34:57PM -0400, Austin Clements wrote:\r
+>> +$(DOCBUILDDIR)/.roff.stamp: ${MAN_RST_FILES}\r
+>>  ifeq ($(HAVE_SPHINX),1)\r
+>>     $(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(DOCBUILDDIR)/man\r
+>>     for section in 1 5 7; do \\r
+>> @@ -48,6 +54,7 @@ else\r
+>>     @echo "Fatal: build dependency fail."\r
+>>     @false\r
+>>  endif\r
+>> +   touch ${MAN_ROFF_FILES} $@\r
+>\r
+> I'm poking around in the Makefile, and don't understand why we're\r
+> touching ${MAN_ROFF_FILES} here.  Either they were just created by\r
+> Sphinx/rst2man, or we died with the @false.  I doubt Sphinx or\r
+> prerst2man.py are intelligent enough to not clobber the roff files if\r
+> their content hasn't changed, but I don't see a point in explicitly\r
+> bumping timestamps either.\r
+>\r
+> I think I'll drop the ${MAN_ROFF_FILES} as part of the patch I'm\r
+> working on, but let me know if I'm just missing something.\r
+\r
+I think you're right.  I can't reconstruct why I touched\r
+${MAN_ROFF_FILES} here.  Touching $@ obviously matters, but I think it\r
+should be safe to drop the ${MAN_ROFF_FILES}.\r
+\r
+> Cheers,\r
+> Trevor\r