Re: [PATCH] test: add tests for `notmuch-hello-refresh-hook'

diff --git a/db/60d5488772ed47bcdb062d9c5cb92e6aeb48c7 b/db/60d5488772ed47bcdb062d9c5cb92e6aeb48c7
new file mode 100644 (file)
index 0000000..1895e29
--- /dev/null
+++ b/db/60d5488772ed47bcdb062d9c5cb92e6aeb48c7
@@ -0,0 +1,80 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C83E9431FD0\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Dec 2011 10:27:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.7\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.7 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id iz4uoxXDMf-7 for <notmuch@notmuchmail.org>;\r
+       Wed, 21 Dec 2011 10:27:26 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 48E47431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Dec 2011 10:27:26 -0800 (PST)\r
+Received: by wibhq2 with SMTP id hq2so2691290wib.26\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Dec 2011 10:27:25 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=Tx6t6tmp86PfbwMcQdvLpd2ZBa4Mt6LMRkkzkH48t1k=;\r
+       b=Pw4GMoH+3c5AgOykHL/B8ybKCD64Jslee5CY0pXwTagUzFwoBmjePNce+Q2uqMc1C+\r
+       TgNHf5VKdRGIkg/se/Ey5SRwxWhX9RFByla4MeBg+MKHb8TPiBPJWhwtqNzFM4aB5GBE\r
+       Y1h81pcX3BvmKqYi15cmgmOHW0wjt6IZv+ZGM=\r
+Received: by 10.181.13.162 with SMTP id ez2mr16549645wid.17.1324492044993;\r
+       Wed, 21 Dec 2011 10:27:24 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id em4sm6726800wbb.20.2011.12.21.10.27.23\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 21 Dec 2011 10:27:23 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Thomas Jost <schnouki@schnouki.net>\r
+Subject: Re: [PATCH] test: add tests for `notmuch-hello-refresh-hook'\r
+In-Reply-To: <1324473189-8622-1-git-send-email-schnouki@schnouki.net>\r
+References: <87iplawvx5.fsf@gmail.com>\r
+       <1324473189-8622-1-git-send-email-schnouki@schnouki.net>\r
+User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 21 Dec 2011 22:26:40 +0400\r
+Message-ID: <871urxwzkv.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 21 Dec 2011 18:27:26 -0000\r
+\r
+Hi Thomas.\r
+\r
+I think all hook count tests must be consistent.  We should either add\r
+hook counters in test-lib.el (like it is already done for\r
+`notmuch-hello-mode-hook') or use lambdas in individual test cases (like\r
+you did in the patch).\r
+\r
+I believe the former approach is better (that is why I used it in the\r
+first place :)).  So I sent patches [1] that add general hook counter to\r
+test-lib.el and `notmuch-hello-mode-hook' tests that use it.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+[1] id:"1324491506-1134-1-git-send-email-dmitry.kurochkin@gmail.com"\r