Re: [PATCH v2] VIM: Use notmuch CLI for config

diff --git a/0a/8ac37323a7c2f8d50368076a6000af4dc7a652 b/0a/8ac37323a7c2f8d50368076a6000af4dc7a652
new file mode 100644 (file)
index 0000000..2dcba67
--- /dev/null
+++ b/0a/8ac37323a7c2f8d50368076a6000af4dc7a652
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6B1E0431FBD\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Oct 2014 23:54:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9L+bbmb+K-pu for <notmuch@notmuchmail.org>;\r
+       Thu,  2 Oct 2014 23:54:30 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4964D431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Oct 2014 23:54:30 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XZwkz-0005NY-4C; Fri, 03 Oct 2014 03:54:25 -0300\r
+Received: (nullmailer pid 18600 invoked by uid 1000); Fri, 03 Oct 2014\r
+       06:54:17 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Ian Main <imain@stemwinder.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] VIM: Use notmuch CLI for config\r
+In-Reply-To: <1412293635-31273-1-git-send-email-imain@stemwinder.org>\r
+References: <1412286796-27479-1-git-send-email-imain@stemwinder.org>\r
+       <1412293635-31273-1-git-send-email-imain@stemwinder.org>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 03 Oct 2014 08:54:17 +0200\r
+Message-ID: <87r3ypr6cm.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 03 Oct 2014 06:54:37 -0000\r
+\r
+Ian Main <imain@stemwinder.org> writes:\r
+\r
+> This patch switches from reading .notmuch-config directly to using\r
+> the CLI the same way that emacs does it.  It actually uses less code\r
+> and is probably less error prone.\r
+>\r
+>     Ian\r
+\r
+The general approach seems sane; it seems quite brittle to read the\r
+config file directly. I notice there is not really any error handling;\r
+OTOH, as far as I can read Ruby, there is not any in the previous\r
+version either.  Technically, this does add a dependency of the vim\r
+client on the CLI that did not exist before. Personally I don't find\r
+this onerous (even notmuch-vim users need "notmuch new", except in\r
+rather unusual circumstances.).\r
+\r
+I'd like feedback/testing from actual vim interface users before\r
+merging.\r
+\r