--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 20FB6431FB6\r
+ for <notmuch@notmuchmail.org>; Sun, 9 Jun 2013 02:17:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id ZUdGqhk3Nej2 for <notmuch@notmuchmail.org>;\r
+ Sun, 9 Jun 2013 02:17:02 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 237F3431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 9 Jun 2013 02:17:02 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Ulbk5-0000CK-MZ; Sun, 09 Jun 2013 10:16:56 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Ulbk5-0004pT-BY; Sun, 09 Jun 2013 10:16:53 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] emacs: Fix "no such file or directory" error\r
+In-Reply-To: <1370753138-15021-3-git-send-email-amdragon@mit.edu>\r
+References: <1370753138-15021-1-git-send-email-amdragon@mit.edu>\r
+ <1370753138-15021-3-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+171~ge2f30a2 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 09 Jun 2013 10:16:52 +0100\r
+Message-ID: <87hah7od8b.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 85f4dfb7015e393840e7ecdfba650ed0 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.0 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 09 Jun 2013 09:17:10 -0000\r
+\r
+\r
+Both of these patches look good to me +1. I was able to reproduce both\r
+bugs pretty reliably (the first one always unless masked by the second\r
+one which occurred about half the time). With these patches I cannot\r
+trigger either. Also all tests pass.\r
+\r
+My only tiny concern is I couldn't find any documentation on whether the\r
+return value of the filter-function matters at all. Austin's original\r
+fix (via irc) returned t and this returns nil in the failing case (i.e.,\r
+when results-buf is dead).\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+On Sun, 09 Jun 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Occasionally, when the user killed the search buffer when the CLI\r
+> process was still running, Emacs would run the\r
+> notmuch-start-notmuch-sentinel sentinel twice. The first call would\r
+> process and delete the error output file and the second would fail\r
+> with an "Opening input file: no such file or directory, ..." error\r
+> when attempting to access the error file.\r
+>\r
+> Emacs isn't supposed to run the sentinel twice. The reason it does is\r
+> rather subtle (and probably a bug in Emacs):\r
+>\r
+> 1) When the user kills the search buffer, Emacs invokes\r
+> kill_buffer_processes, which sends a SIGHUP to notmuch, but doesn't do\r
+> anything else. Meanwhile, suppose the notmuch search process has\r
+> printed some more output, but Emacs hasn't consumed it yet (this is\r
+> critical and is why this error only happens sometimes).\r
+>\r
+> 2) Emacs gets a SIGCHLD from the dying notmuch process, which invokes\r
+> handle_child_signal, which sets the new process status, but can't do\r
+> anything else because it's a signal handler.\r
+>\r
+> 3) Emacs returns to its idle loop, which calls status_notify, which\r
+> sees that the notmuch process has a new status. This is where things\r
+> get interesting.\r
+>\r
+> 3.1) Emacs guarantees that it will run process filters on any\r
+> unconsumed output before running the process sentinel, so\r
+> status_notify calls read_process_output, which consumes the final\r
+> output and calls notmuch-search-process-filter.\r
+>\r
+> 3.1.1) notmuch-search-process-filter checks if the search buffer is\r
+> still alive and, since it's not, it calls delete-process.\r
+>\r
+> 3.1.1.1) delete-process correctly sees that the process is already\r
+> dead and doesn't try to send another signal, *but* it still modifies\r
+> the status to "killed". To deal with the new status, it calls\r
+> status_notify. Dun dun dun. We've seen this function before.\r
+>\r
+> 3.1.1.1.1) The *recursive* status_notify invocation sees that the\r
+> process has a new status and doesn't have any more output to consume,\r
+> so it invokes our sentinel and returns.\r
+>\r
+> 3.2) The outer status_notify call (which we're still in) is now done\r
+> flushing pending process output, so it *also* invokes our sentinel.\r
+>\r
+> This patch addresses this problem at step 3.1.1, where the filter\r
+> calls delete-process, since this is a strange and redundant thing to\r
+> do anyway.\r
+> ---\r
+> emacs/notmuch.el | 3 +--\r
+> 1 file changed, 1 insertion(+), 2 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 7994d74..a9949a1 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -821,8 +821,7 @@ non-authors is found, assume that all of the authors match."\r
+> (parse-buf (process-get proc 'parse-buf))\r
+> (inhibit-read-only t)\r
+> done)\r
+> - (if (not (buffer-live-p results-buf))\r
+> - (delete-process proc)\r
+> + (when (buffer-live-p results-buf)\r
+> (with-current-buffer parse-buf\r
+> ;; Insert new data\r
+> (save-excursion\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff